From 56c6f8bbb212ab508c9e53e6a0cd495c2a68142d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Tue, 21 Apr 2026 18:38:02 +0200 Subject: [PATCH] docs: Fix shellcheck issues in offline_cpu.sh MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix shellcheck warnings and notes identified by running shellcheck --severity=style. Signed-off-by: Fabiano FidĂȘncio --- docs/how-to/offline_cpu.sh | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/docs/how-to/offline_cpu.sh b/docs/how-to/offline_cpu.sh index 78fe24bbfe..5fb0813570 100644 --- a/docs/how-to/offline_cpu.sh +++ b/docs/how-to/offline_cpu.sh @@ -5,19 +5,19 @@ # # Description: Offline SOS CPUs except BSP before launch UOS -[ $(id -u) -eq 0 ] || { echo >&2 "ERROR: run as root"; exit 1; } +[[ $(id -u) -eq 0 ]] || { echo >&2 "ERROR: run as root"; exit 1; } -for i in $(ls -d /sys/devices/system/cpu/cpu[1-9]*); do - online=`cat $i/online` - idx=`echo $i | tr -cd "[0-9]"` - echo "INFO:$0: cpu$idx online=$online" - if [ "$online" = "1" ]; then - echo 0 > $i/online - while [ "$online" = "1" ]; do +for i in /sys/devices/system/cpu/cpu[1-9]*; do + [[ -e "${i}/online" ]] || continue + online=$(cat "${i}/online") + idx=$(echo "${i}" | tr -cd "0-9") + echo "INFO:$0: cpu${idx} online=${online}" + if [[ "${online}" = "1" ]]; then + echo 0 > "${i}/online" + while [[ "${online}" = "1" ]]; do sleep 1 - echo 0 > $i/online - online=`cat $i/online` + echo 0 > "${i}/online" + online=$(cat "${i}/online") done fi done -