diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index a3c8b6e745..b3c1c0e8e4 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -223,7 +223,10 @@ jobs: run-kata-coco-tests: if: ${{ inputs.skip-test != 'yes' }} - needs: [publish-kata-deploy-payload-amd64, build-and-publish-tee-confidential-unencrypted-image] + needs: + - publish-kata-deploy-payload-amd64 + - build-and-publish-tee-confidential-unencrypted-image + - publish-csi-driver-amd64 uses: ./.github/workflows/run-kata-coco-tests.yaml with: tarball-suffix: -${{ inputs.tag }} diff --git a/src/tools/csi-kata-directvolume/.gitignore b/src/tools/csi-kata-directvolume/.gitignore new file mode 100644 index 0000000000..e660fd93d3 --- /dev/null +++ b/src/tools/csi-kata-directvolume/.gitignore @@ -0,0 +1 @@ +bin/ diff --git a/src/tools/csi-kata-directvolume/release-tools/build.make b/src/tools/csi-kata-directvolume/release-tools/build.make index 23f3e54b62..27fff519e4 100644 --- a/src/tools/csi-kata-directvolume/release-tools/build.make +++ b/src/tools/csi-kata-directvolume/release-tools/build.make @@ -56,7 +56,7 @@ ARCH := $(if $(GOARCH),$(GOARCH),$(shell go env GOARCH)) # Specific packages can be excluded from each of the tests below by setting the *_FILTER_CMD variables # to something like "| grep -v 'github.com/kubernetes-csi/project/pkg/foobar'". See usage below. -build-%: check-go-version-go +build-%: mkdir -p bin CGO_ENABLED=0 GOOS=linux go build $(GOFLAGS_VENDOR) -a -ldflags '-X main.version=$(REV) -extldflags "-static"' -o ./bin/$* ./cmd/$* if [ "$$ARCH" = "amd64" ]; then \ @@ -92,9 +92,6 @@ push: $(CMDS:%=push-%) clean: -rm -rf bin -test: check-go-version-go - - .PHONY: test-vet test: test-vet test-vet: @@ -111,12 +108,3 @@ test-fmt: gofmt -d $$files; \ false; \ fi - - -# Targets in the makefile can depend on check-go-version- -# to trigger a warning if the x.y version of that binary does not match -# what the project uses. Make ensures that this is only checked once per -# invocation. -.PHONY: check-go-version-% -check-go-version-%: - ./release-tools/verify-go-version.sh "$*" diff --git a/src/tools/csi-kata-directvolume/release-tools/verify-go-version.sh b/src/tools/csi-kata-directvolume/release-tools/verify-go-version.sh deleted file mode 100755 index 9c35c0c97b..0000000000 --- a/src/tools/csi-kata-directvolume/release-tools/verify-go-version.sh +++ /dev/null @@ -1,35 +0,0 @@ -#!/usr/bin/env bash -# -# Copyright 2019 The Kubernetes Authors. -# -# SPDX-License-Identifier: Apache-2.0 -# - -GO="$1" - -if [ ! "$GO" ]; then - echo >&2 "usage: $0 " - exit 1 -fi - -die () { - echo "ERROR: $*" - exit 1 -} - -version=$("$GO" version) || die "determining version of $GO failed" -# shellcheck disable=SC2001 -majorminor=$(echo "$version" | sed -e 's/.*go\([0-9]*\)\.\([0-9]*\).*/\1.\2/') - -if [ "$majorminor" != "$expected" ]; then - cat >&2 <