From 59883a2d99ec0cad49ea377d622801087a612e76 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Wed, 22 Oct 2025 20:38:35 +0200 Subject: [PATCH] actions: Remove unused USING_NFD MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There's no reason to keep the env var / input as it's never been used and now kata-deploy detects automatically whether NFD is deployed or not. Signed-off-by: Fabiano Fidêncio --- .github/workflows/run-k8s-tests-on-aks.yaml | 1 - .github/workflows/run-k8s-tests-on-amd64.yaml | 1 - .github/workflows/run-k8s-tests-on-arm64.yaml | 1 - .github/workflows/run-k8s-tests-on-nvidia-gpu.yaml | 1 - .github/workflows/run-k8s-tests-on-ppc64le.yaml | 1 - .github/workflows/run-k8s-tests-on-zvsi.yaml | 3 --- .github/workflows/run-kata-coco-stability-tests.yaml | 1 - .github/workflows/run-kata-coco-tests.yaml | 3 --- .github/workflows/run-kata-deploy-tests-on-aks.yaml | 1 - .github/workflows/run-kata-deploy-tests.yaml | 1 - .github/workflows/run-metrics.yaml | 1 - 11 files changed, 15 deletions(-) diff --git a/.github/workflows/run-k8s-tests-on-aks.yaml b/.github/workflows/run-k8s-tests-on-aks.yaml index 7827ef93c6..d64166c45f 100644 --- a/.github/workflows/run-k8s-tests-on-aks.yaml +++ b/.github/workflows/run-k8s-tests-on-aks.yaml @@ -79,7 +79,6 @@ jobs: KATA_HOST_OS: ${{ matrix.host_os }} KATA_HYPERVISOR: ${{ matrix.vmm }} KUBERNETES: "vanilla" - USING_NFD: "false" K8S_TEST_HOST_TYPE: ${{ matrix.instance-type }} GENPOLICY_PULL_METHOD: ${{ matrix.genpolicy-pull-method }} steps: diff --git a/.github/workflows/run-k8s-tests-on-amd64.yaml b/.github/workflows/run-k8s-tests-on-amd64.yaml index 94a8cfbd15..4b7d72be27 100644 --- a/.github/workflows/run-k8s-tests-on-amd64.yaml +++ b/.github/workflows/run-k8s-tests-on-amd64.yaml @@ -53,7 +53,6 @@ jobs: KUBERNETES: ${{ matrix.k8s }} KUBERNETES_EXTRA_PARAMS: ${{ matrix.container_runtime != 'crio' && '' || '--cri-socket remote:unix:///var/run/crio/crio.sock --kubelet-extra-args --cgroup-driver="systemd"' }} SNAPSHOTTER: ${{ matrix.snapshotter }} - USING_NFD: "false" K8S_TEST_HOST_TYPE: all CONTAINER_RUNTIME: ${{ matrix.container_runtime }} steps: diff --git a/.github/workflows/run-k8s-tests-on-arm64.yaml b/.github/workflows/run-k8s-tests-on-arm64.yaml index 58715c7458..007e556e37 100644 --- a/.github/workflows/run-k8s-tests-on-arm64.yaml +++ b/.github/workflows/run-k8s-tests-on-arm64.yaml @@ -42,7 +42,6 @@ jobs: GH_PR_NUMBER: ${{ inputs.pr-number }} KATA_HYPERVISOR: ${{ matrix.vmm }} KUBERNETES: ${{ matrix.k8s }} - USING_NFD: "false" K8S_TEST_HOST_TYPE: all TARGET_ARCH: "aarch64" steps: diff --git a/.github/workflows/run-k8s-tests-on-nvidia-gpu.yaml b/.github/workflows/run-k8s-tests-on-nvidia-gpu.yaml index fab2043748..77cd2cdf39 100644 --- a/.github/workflows/run-k8s-tests-on-nvidia-gpu.yaml +++ b/.github/workflows/run-k8s-tests-on-nvidia-gpu.yaml @@ -45,7 +45,6 @@ jobs: GH_PR_NUMBER: ${{ inputs.pr-number }} KATA_HYPERVISOR: ${{ matrix.vmm }} KUBERNETES: ${{ matrix.k8s }} - USING_NFD: "false" K8S_TEST_HOST_TYPE: all steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 diff --git a/.github/workflows/run-k8s-tests-on-ppc64le.yaml b/.github/workflows/run-k8s-tests-on-ppc64le.yaml index 51fdfc2bb5..9c8afc733a 100644 --- a/.github/workflows/run-k8s-tests-on-ppc64le.yaml +++ b/.github/workflows/run-k8s-tests-on-ppc64le.yaml @@ -43,7 +43,6 @@ jobs: GOPATH: ${{ github.workspace }} KATA_HYPERVISOR: ${{ matrix.vmm }} KUBERNETES: ${{ matrix.k8s }} - USING_NFD: "false" TARGET_ARCH: "ppc64le" steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 diff --git a/.github/workflows/run-k8s-tests-on-zvsi.yaml b/.github/workflows/run-k8s-tests-on-zvsi.yaml index 8fbbc6955b..154a744333 100644 --- a/.github/workflows/run-k8s-tests-on-zvsi.yaml +++ b/.github/workflows/run-k8s-tests-on-zvsi.yaml @@ -46,11 +46,9 @@ jobs: include: - snapshotter: devmapper pull-type: default - using-nfd: true deploy-cmd: configure-snapshotter - snapshotter: nydus pull-type: guest-pull - using-nfd: false deploy-cmd: deploy-snapshotter exclude: - snapshotter: overlayfs @@ -76,7 +74,6 @@ jobs: KUBERNETES: ${{ matrix.k8s }} PULL_TYPE: ${{ matrix.pull-type }} SNAPSHOTTER: ${{ matrix.snapshotter }} - USING_NFD: ${{ matrix.using-nfd }} TARGET_ARCH: "s390x" AUTHENTICATED_IMAGE_USER: ${{ vars.AUTHENTICATED_IMAGE_USER }} AUTHENTICATED_IMAGE_PASSWORD: ${{ secrets.AUTHENTICATED_IMAGE_PASSWORD }} diff --git a/.github/workflows/run-kata-coco-stability-tests.yaml b/.github/workflows/run-kata-coco-stability-tests.yaml index bb88a199e4..1da2ba0a53 100644 --- a/.github/workflows/run-kata-coco-stability-tests.yaml +++ b/.github/workflows/run-kata-coco-stability-tests.yaml @@ -70,7 +70,6 @@ jobs: AUTHENTICATED_IMAGE_USER: ${{ vars.AUTHENTICATED_IMAGE_USER }} AUTHENTICATED_IMAGE_PASSWORD: ${{ secrets.AUTHENTICATED_IMAGE_PASSWORD }} SNAPSHOTTER: ${{ matrix.snapshotter }} - USING_NFD: "false" steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 with: diff --git a/.github/workflows/run-kata-coco-tests.yaml b/.github/workflows/run-kata-coco-tests.yaml index 71084835f5..fc77c761fa 100644 --- a/.github/workflows/run-kata-coco-tests.yaml +++ b/.github/workflows/run-kata-coco-tests.yaml @@ -57,7 +57,6 @@ jobs: GH_PR_NUMBER: ${{ inputs.pr-number }} KATA_HYPERVISOR: ${{ matrix.vmm }} KUBERNETES: "vanilla" - USING_NFD: "false" KBS: "true" K8S_TEST_HOST_TYPE: "baremetal" KBS_INGRESS: "nodeport" @@ -163,7 +162,6 @@ jobs: # host type chose it will result on the creation of a cluster with # insufficient resources. K8S_TEST_HOST_TYPE: "all" - USING_NFD: "false" steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 with: @@ -284,7 +282,6 @@ jobs: SNAPSHOTTER: ${{ matrix.snapshotter }} USE_EXPERIMENTAL_SETUP_SNAPSHOTTER: "true" K8S_TEST_HOST_TYPE: "all" - USING_NFD: "false" # We are skipping the auto generated policy tests for now, # but those should be enabled as soon as we work on that. AUTO_GENERATE_POLICY: "no" diff --git a/.github/workflows/run-kata-deploy-tests-on-aks.yaml b/.github/workflows/run-kata-deploy-tests-on-aks.yaml index 84f2c312b3..e99274b5da 100644 --- a/.github/workflows/run-kata-deploy-tests-on-aks.yaml +++ b/.github/workflows/run-kata-deploy-tests-on-aks.yaml @@ -59,7 +59,6 @@ jobs: KATA_HOST_OS: ${{ matrix.host_os }} KATA_HYPERVISOR: ${{ matrix.vmm }} KUBERNETES: "vanilla" - USING_NFD: "false" steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 with: diff --git a/.github/workflows/run-kata-deploy-tests.yaml b/.github/workflows/run-kata-deploy-tests.yaml index 11601c3abc..bd2365b4e3 100644 --- a/.github/workflows/run-kata-deploy-tests.yaml +++ b/.github/workflows/run-kata-deploy-tests.yaml @@ -45,7 +45,6 @@ jobs: GH_PR_NUMBER: ${{ inputs.pr-number }} KATA_HYPERVISOR: ${{ matrix.vmm }} KUBERNETES: ${{ matrix.k8s }} - USING_NFD: "false" steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 with: diff --git a/.github/workflows/run-metrics.yaml b/.github/workflows/run-metrics.yaml index e19234a811..519440bdaf 100644 --- a/.github/workflows/run-metrics.yaml +++ b/.github/workflows/run-metrics.yaml @@ -44,7 +44,6 @@ jobs: DOCKER_TAG: ${{ inputs.tag }} GH_PR_NUMBER: ${{ inputs.pr-number }} K8S_TEST_HOST_TYPE: "baremetal" - USING_NFD: "false" KUBERNETES: kubeadm steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2