From 59f104c02290dbcee5c42125527e79493578e51c Mon Sep 17 00:00:00 2001 From: Jianyong Wu Date: Thu, 2 Feb 2023 13:28:40 +0800 Subject: [PATCH] runtime: skip unit test that fail regularly on aarch64 There are lots of unit test cases fails regularly on aarch64, including TestIOCopy, create_tmpfs. Temporarily skip it for now and enable it after them get fixed. Fixes: #6194 Signed-off-by: Jianyong Wu --- src/agent/src/watcher.rs | 1 + src/runtime/pkg/containerd-shim-v2/stream_test.go | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/src/agent/src/watcher.rs b/src/agent/src/watcher.rs index 468684a431..a6cf4113b4 100644 --- a/src/agent/src/watcher.rs +++ b/src/agent/src/watcher.rs @@ -1291,6 +1291,7 @@ mod tests { #[tokio::test] #[serial] + #[cfg(not(target_arch = "aarch64"))] async fn create_tmpfs() { skip_if_not_root!(); diff --git a/src/runtime/pkg/containerd-shim-v2/stream_test.go b/src/runtime/pkg/containerd-shim-v2/stream_test.go index ea4f026ca1..c85633c884 100644 --- a/src/runtime/pkg/containerd-shim-v2/stream_test.go +++ b/src/runtime/pkg/containerd-shim-v2/stream_test.go @@ -10,6 +10,7 @@ import ( "io" "os" "path/filepath" + "runtime" "syscall" "testing" "time" @@ -96,6 +97,10 @@ func TestNewTtyIOFifoReopen(t *testing.T) { } func TestIoCopy(t *testing.T) { + // This test fails on aarch64 regularly, temporarily skip it + if runtime.GOARCH == "arm64" { + t.Skip("Skip TestIoCopy for aarch64") + } assert := assert.New(t) ctx := context.TODO()