From babab160bc6182fb31eefc299f80eff6e9cb735f Mon Sep 17 00:00:00 2001 From: Greg Kurz Date: Thu, 29 Sep 2022 11:29:57 +0200 Subject: [PATCH] tools: release: fix bogus version check Shell expands `*"rc"*` to the top-level `src` directory. This results in comparing a version with a directory name. This doesn't make sense and causes the script to choose the wrong branch of the `if`. The intent of the check is actually to detect `rc` in the version. Fixes: #5283 Signed-off-by: Greg Kurz (cherry picked from commit 421729f99136522a76ce199947a0a197a1d07801) Signed-off-by: Greg Kurz --- tools/packaging/release/update-repository-version.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/packaging/release/update-repository-version.sh b/tools/packaging/release/update-repository-version.sh index 2335d4f9e8..26f48daa16 100755 --- a/tools/packaging/release/update-repository-version.sh +++ b/tools/packaging/release/update-repository-version.sh @@ -191,7 +191,7 @@ bump_repo() { need_commit=true fi - elif [ "${new_version}" != *"rc"* ]; then + elif [[ ! "${new_version}" =~ "rc" ]]; then ## We are on a stable branch and creating new stable releases. ## Need to change kata-deploy / kata-cleanup to use the stable tags. if [[ "${version_to_replace}" =~ "rc" ]]; then