From 6a4919eeb9bfd86c3a4d74ce02b31c1f9eb85aef Mon Sep 17 00:00:00 2001 From: Pavel Mores Date: Tue, 18 Jun 2024 12:11:59 +0200 Subject: [PATCH] runtime-rs: fix misleading log message get_vmm_master_tid() currently returns an error with the message "cannot get qemu pid (though it seems running)" when it finds a valid QemuInner::qemu_process instance but fails to extract the PID out of it. This condition however in fact means that a qemu child process was running (otherwise QemuInner::qemu_process would be None) but isn't anymore (id() returns None). Signed-off-by: Pavel Mores --- src/runtime-rs/crates/hypervisor/src/qemu/inner.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/runtime-rs/crates/hypervisor/src/qemu/inner.rs b/src/runtime-rs/crates/hypervisor/src/qemu/inner.rs index d87e22b366..ae5108099e 100644 --- a/src/runtime-rs/crates/hypervisor/src/qemu/inner.rs +++ b/src/runtime-rs/crates/hypervisor/src/qemu/inner.rs @@ -231,7 +231,7 @@ impl QemuInner { ); Ok(qemu_pid) } else { - Err(anyhow!("cannot get qemu pid (though it seems running)")) + Err(anyhow!("QemuInner::get_vmm_master_tid(): qemu process isn't running (likely stopped already)")) } } else { Err(anyhow!("qemu process not running"))