From 395e93acd5f7e9f71854fad5a311131702ef3f8b Mon Sep 17 00:00:00 2001 From: Zvonko Kaiser Date: Wed, 17 Apr 2024 09:38:52 +0000 Subject: [PATCH] kata: Remove Issue - PR dependency We've discussed this over and over. Let's try to get to an agreement here. I will use this issue to remove the mandatory Issue - PR dependency. Fixes: #9500 Signed-off-by: Zvonko Kaiser --- .github/workflows/commit-message-check.yaml | 11 ----------- .github/workflows/move-issues-to-in-progress.yaml | 7 +++---- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/.github/workflows/commit-message-check.yaml b/.github/workflows/commit-message-check.yaml index b54c0a7e40..177709f84c 100644 --- a/.github/workflows/commit-message-check.yaml +++ b/.github/workflows/commit-message-check.yaml @@ -86,17 +86,6 @@ jobs: error: 'Body line too long (max 150)' post_error: ${{ env.error_msg }} - - name: Check Fixes - if: ${{ !contains(github.event.pull_request.labels.*.name, 'force-skip-ci') && ( success() || failure() ) }} - uses: tim-actions/commit-message-checker-with-regex@v0.3.1 - with: - commits: ${{ steps.get-pr-commits.outputs.commits }} - pattern: '\s*Fixes\s*:?\s*(#\d+|github\.com\/kata-containers\/[a-z-.]*#\d+)|^\s*release\s*:' - flags: 'i' - error: 'No "Fixes" found' - post_error: ${{ env.error_msg }} - one_pass_all_pass: 'true' - - name: Check Subsystem if: ${{ !contains(github.event.pull_request.labels.*.name, 'force-skip-ci') && ( success() || failure() ) }} uses: tim-actions/commit-message-checker-with-regex@v0.3.1 diff --git a/.github/workflows/move-issues-to-in-progress.yaml b/.github/workflows/move-issues-to-in-progress.yaml index 1ecd8a095e..43583f9b07 100644 --- a/.github/workflows/move-issues-to-in-progress.yaml +++ b/.github/workflows/move-issues-to-in-progress.yaml @@ -62,11 +62,10 @@ jobs: grep -v "^\#" |\ cut -d';' -f3 || true) - # PR doesn't have any linked issues - # (it should, but maybe a new user forgot to add a "Fixes: #XXX" commit). + # PR doesn't have any linked issues, handle it only if it exists [ -z "$linked_issue_urls" ] && { - echo "::error::No linked issues for PR $pr" - exit 1 + echo "::warning::No linked issues for PR $pr" + exit 0 } project_name="Issue backlog"