mirror of
https://github.com/kata-containers/kata-containers.git
synced 2025-04-30 12:44:39 +00:00
shimv2: add information to method comment
add a comment to explicitly mentioned method is a binary call Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
This commit is contained in:
parent
8dadca9cd1
commit
72e3538e36
@ -181,8 +181,8 @@ func newCommand(ctx context.Context, id, containerdBinary, containerdAddress str
|
|||||||
return cmd, nil
|
return cmd, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// StartShim willl start a kata shimv2 daemon which will implemented the
|
// StartShim is a binary call that starts a kata shimv2 service which will
|
||||||
// ShimV2 APIs such as create/start/update etc containers.
|
// implement the ShimV2 APIs such as create/start/update etc containers.
|
||||||
func (s *service) StartShim(ctx context.Context, opts cdshim.StartOpts) (_ string, retErr error) {
|
func (s *service) StartShim(ctx context.Context, opts cdshim.StartOpts) (_ string, retErr error) {
|
||||||
bundlePath, err := os.Getwd()
|
bundlePath, err := os.Getwd()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@ -310,6 +310,7 @@ func getTopic(e interface{}) string {
|
|||||||
return cdruntime.TaskUnknownTopic
|
return cdruntime.TaskUnknownTopic
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Cleanup is a binary call that cleans up resources used by the shim
|
||||||
func (s *service) Cleanup(ctx context.Context) (_ *taskAPI.DeleteResponse, err error) {
|
func (s *service) Cleanup(ctx context.Context) (_ *taskAPI.DeleteResponse, err error) {
|
||||||
span, spanCtx := katatrace.Trace(s.rootCtx, shimLog, "Cleanup", shimTracingTags)
|
span, spanCtx := katatrace.Trace(s.rootCtx, shimLog, "Cleanup", shimTracingTags)
|
||||||
defer span.End()
|
defer span.End()
|
||||||
|
Loading…
Reference in New Issue
Block a user