diff --git a/tools/packaging/scripts/lib.sh b/tools/packaging/scripts/lib.sh index 5e7067bab0..957154233d 100644 --- a/tools/packaging/scripts/lib.sh +++ b/tools/packaging/scripts/lib.sh @@ -19,16 +19,7 @@ short_commit_length=10 gh_cli="gh-cli" -#for cross build -CROSS_BUILD=${CROSS_BUILD-:} -BUILDX="" -PLATFORM="" -TARGET_ARCH=${TARGET_ARCH:-$(uname -m)} ARCH=${ARCH:-$(uname -m)} -[[ "${TARGET_ARCH}" == "aarch64" ]] && TARGET_ARCH=arm64 -TARGET_OS=${TARGET_OS:-linux} -# shellcheck disable=SC2034 -[[ "${CROSS_BUILD}" == "true" ]] && BUILDX=buildx && PLATFORM="--platform=${TARGET_OS}/${TARGET_ARCH}" install_yq() { pushd "${repo_root_dir}" || return diff --git a/tools/packaging/static-build/agent/build.sh b/tools/packaging/static-build/agent/build.sh index 13d111d855..992b14ca4b 100755 --- a/tools/packaging/static-build/agent/build.sh +++ b/tools/packaging/static-build/agent/build.sh @@ -15,12 +15,10 @@ readonly agent_builder="${script_dir}/build-static-agent.sh" source "${script_dir}/../../scripts/lib.sh" container_image="${AGENT_CONTAINER_BUILDER:-$(get_agent_image_name)}" -# shellcheck disable=SC2154 -[[ "${CROSS_BUILD}" == "true" ]] && container_image="${container_image}-cross-build" # shellcheck disable=SC2154,SC2086 docker pull "${container_image}" || \ - (docker ${BUILDX} build ${PLATFORM} \ + (docker build \ --build-arg RUST_TOOLCHAIN="$(get_from_kata_deps ".languages.rust.meta.newest-version")" \ -t "${container_image}" "${script_dir}" && \ # No-op unless PUSH_TO_REGISTRY is exported as "yes" diff --git a/tools/packaging/static-build/busybox/build.sh b/tools/packaging/static-build/busybox/build.sh index 0b2fe9169c..3b717bba17 100755 --- a/tools/packaging/static-build/busybox/build.sh +++ b/tools/packaging/static-build/busybox/build.sh @@ -27,12 +27,10 @@ readonly BUSYBOX_URL="${busybox_url}" container_image="${BUSYBOX_CONTAINER_BUILDER:-$(get_busybox_image_name)}" -# shellcheck disable=SC2154 -[[ "${CROSS_BUILD}" == "true" ]] && container_image="${container_image}-cross-build" # shellcheck disable=SC2154,SC2086 docker pull "${container_image}" || \ - (docker ${BUILDX} build ${PLATFORM} \ + (docker build \ -t "${container_image}" "${script_dir}" \ # No-op unless PUSH_TO_REGISTRY is exported as "yes" push_to_registry "${container_image}") diff --git a/tools/packaging/static-build/coco-guest-components/build.sh b/tools/packaging/static-build/coco-guest-components/build.sh index f197ff565d..b4236cf8a1 100755 --- a/tools/packaging/static-build/coco-guest-components/build.sh +++ b/tools/packaging/static-build/coco-guest-components/build.sh @@ -33,12 +33,10 @@ nvat_version="${nvat_version:-}" [[ -n "${nvat_version}" ]] || nvat_version=$(get_from_kata_deps ".externals.nvidia.nvat.version" 2>/dev/null || true) container_image="${COCO_GUEST_COMPONENTS_CONTAINER_BUILDER:-$(get_coco_guest_components_image_name)}" -# shellcheck disable=SC2154 -[[ "${CROSS_BUILD}" == "true" ]] && container_image="${container_image}-cross-build" # shellcheck disable=SC2154,SC2086 docker pull "${container_image}" || \ - (docker ${BUILDX} build ${PLATFORM} \ + (docker build \ --build-arg RUST_TOOLCHAIN="${coco_guest_components_toolchain}" \ --build-arg NVAT_VERSION="${nvat_version}" \ -t "${container_image}" "${script_dir}" && \ diff --git a/tools/packaging/static-build/pause-image/build.sh b/tools/packaging/static-build/pause-image/build.sh index 5748d057ba..2e2cf2fbac 100755 --- a/tools/packaging/static-build/pause-image/build.sh +++ b/tools/packaging/static-build/pause-image/build.sh @@ -27,12 +27,10 @@ package_output_dir="${package_output_dir:-}" [[ -n "${pause_image_version}" ]] || die "Failed to get pause image version or commit" container_image="${PAUSE_IMAGE_CONTAINER_BUILDER:-$(get_pause_image_name)}" -# shellcheck disable=SC2154 -[[ "${CROSS_BUILD}" == "true" ]] && container_image="${container_image}-cross-build" # shellcheck disable=SC2154,SC2086 docker pull "${container_image}" || \ - (docker ${BUILDX} build ${PLATFORM} \ + (docker build \ -t "${container_image}" "${script_dir}" && \ # No-op unless PUSH_TO_REGISTRY is exported as "yes" push_to_registry "${container_image}") diff --git a/tools/packaging/static-build/shim-v2/build.sh b/tools/packaging/static-build/shim-v2/build.sh index a7eec5c51b..dd8c71254e 100755 --- a/tools/packaging/static-build/shim-v2/build.sh +++ b/tools/packaging/static-build/shim-v2/build.sh @@ -19,7 +19,6 @@ VMM_CONFIGS="qemu fc" GO_VERSION=${GO_VERSION} # shellcheck disable=SC2269 RUST_VERSION=${RUST_VERSION} -CC="" RUNTIME_CHOICE="${RUNTIME_CHOICE:-both}" DESTDIR=${DESTDIR:-${PWD}} @@ -38,9 +37,6 @@ case "${RUNTIME_CHOICE}" in ;; esac -# shellcheck disable=SC2154 -[[ "${CROSS_BUILD}" == "true" ]] && container_image_bk="${container_image}" && container_image="${container_image}-cross-build" - # Variants (targets) that build a measured rootfs as of now are: # - rootfs-image (the base image, measured; root hash labelled "base") # - rootfs-image-confidential (monolithic CoCo image, root hash "confidential") @@ -105,7 +101,7 @@ GO_EXTRA_OPTS+="$(read_verity_param "nvidia" "KERNELVERITYPARAMS_NV_BASE")" # shellcheck disable=SC2154,SC2086 docker pull "${container_image}" || \ - (docker ${BUILDX} build ${PLATFORM} \ + (docker build \ --build-arg GO_VERSION="${GO_VERSION}" \ --build-arg RUST_VERSION="${RUST_VERSION}" \ -t "${container_image}" \ @@ -113,30 +109,21 @@ docker pull "${container_image}" || \ push_to_registry "${container_image}") arch=${ARCH:-$(uname -m)} -GCC_ARCH=${arch} if [[ "${arch}" = "ppc64le" ]]; then - GCC_ARCH="powerpc64le" arch="ppc64" fi case "${RUNTIME_CHOICE}" in "rust"|"both") - #Build rust project using cross build musl image to speed up - [[ "${CROSS_BUILD}" == "true" && ${ARCH} != "s390x" ]] && container_image="messense/rust-musl-cross:${GCC_ARCH}-musl" && CC=${GCC_ARCH}-unknown-linux-musl-gcc - docker run --rm -i -v "${repo_root_dir}:${repo_root_dir}" \ - --env CROSS_BUILD="${CROSS_BUILD}" \ --env ARCH="${ARCH}" \ - --env CC="${CC}" \ -w "${repo_root_dir}/src/runtime-rs" \ --user "$(id -u)":"$(id -g)" \ "${container_image}" \ bash -c "make clean-generated-files && make PREFIX=${PREFIX} QEMUCMD=qemu-system-${arch} ${EXTRA_OPTS}${RUST_EXTRA_OPTS}" docker run --rm -i -v "${repo_root_dir}:${repo_root_dir}" \ - --env CROSS_BUILD="${CROSS_BUILD}" \ --env ARCH="${ARCH}" \ - --env CC="${CC}" \ -w "${repo_root_dir}/src/runtime-rs" \ --user "$(id -u)":"$(id -g)" \ "${container_image}" \ @@ -154,8 +141,6 @@ fi case "${RUNTIME_CHOICE}" in "go"|"both") - [[ "${CROSS_BUILD}" == "true" ]] && container_image="${container_image_bk}-cross-build" - docker run --rm -i -v "${repo_root_dir}:${repo_root_dir}" \ -w "${repo_root_dir}/src/runtime" \ --user "$(id -u)":"$(id -g)" \ diff --git a/tools/packaging/static-build/tools/build.sh b/tools/packaging/static-build/tools/build.sh index bb177a9ff4..55b8790278 100755 --- a/tools/packaging/static-build/tools/build.sh +++ b/tools/packaging/static-build/tools/build.sh @@ -17,12 +17,10 @@ source "${script_dir}/../../scripts/lib.sh" tool="${1}" container_image="${TOOLS_CONTAINER_BUILDER:-$(get_tools_image_name)}" -# shellcheck disable=SC2154 -[[ "${CROSS_BUILD}" == "true" ]] && container_image="${container_image}-cross-build" # shellcheck disable=SC2154,SC2086 docker pull "${container_image}" || \ - (docker ${BUILDX} build ${PLATFORM} \ + (docker build \ --build-arg GO_TOOLCHAIN="$(get_from_kata_deps ".languages.golang.meta.newest-version")" \ --build-arg RUST_TOOLCHAIN="$(get_from_kata_deps ".languages.rust.meta.newest-version")" \ -t "${container_image}" "${script_dir}" && \ diff --git a/tools/packaging/static-build/virtiofsd/build.sh b/tools/packaging/static-build/virtiofsd/build.sh index b2de1a7471..92abf11c48 100755 --- a/tools/packaging/static-build/virtiofsd/build.sh +++ b/tools/packaging/static-build/virtiofsd/build.sh @@ -52,12 +52,10 @@ case ${ARCH} in esac container_image="${VIRTIOFSD_CONTAINER_BUILDER:-$(get_virtiofsd_image_name)}" -# shellcheck disable=SC2154 -[[ "${CROSS_BUILD}" == "true" ]] && container_image="${container_image}-cross-build" # shellcheck disable=SC2154,SC2086 docker pull "${container_image}" || \ - (docker ${BUILDX} build ${PLATFORM} \ + (docker build \ --build-arg RUST_TOOLCHAIN="${virtiofsd_toolchain}" \ -t "${container_image}" "${script_dir}/${libc}" && \ # No-op unless PUSH_TO_REGISTRY is exported as "yes"