From 8360f9eef73589ea8f146249a40bb8496456b7a4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <ffidencio@nvidia.com>
Date: Tue, 21 Apr 2026 18:15:35 +0200
Subject: [PATCH] tools: Fix shellcheck issues in build-static-firecracker.sh
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Address shellcheck warnings including proper variable quoting,
use of [[ ]] over [ ], declaring and assigning variables separately,
and adding appropriate shellcheck disable directives where needed.

Signed-off-by: Fabiano Fidêncio <ffidencio@nvidia.com>
Made-with: Cursor
---
 .../firecracker/build-static-firecracker.sh   | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/tools/packaging/static-build/firecracker/build-static-firecracker.sh b/tools/packaging/static-build/firecracker/build-static-firecracker.sh
index 7c29be3493..e2150f264f 100755
--- a/tools/packaging/static-build/firecracker/build-static-firecracker.sh
+++ b/tools/packaging/static-build/firecracker/build-static-firecracker.sh
@@ -10,21 +10,24 @@ set -o pipefail
 
 script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
+# shellcheck source=/dev/null
 source "${script_dir}/../../scripts/lib.sh"
 
+# shellcheck disable=SC2034
 config_dir="${script_dir}/../../scripts/"
 
 firecracker_url="${firecracker_url:-}"
+# shellcheck disable=SC2034
 firecracker_dir="firecracker"
 firecracker_version="${firecracker_version:-}"
 
 arch=$(uname -m)
 
-[ -n "$firecracker_url" ] ||firecracker_url=$(get_from_kata_deps ".assets.hypervisor.firecracker.url")
-[ -n "$firecracker_url" ] || die "failed to get firecracker url"
+[[ -n "${firecracker_url}" ]] ||firecracker_url=$(get_from_kata_deps ".assets.hypervisor.firecracker.url")
+[[ -n "${firecracker_url}" ]] || die "failed to get firecracker url"
 
-[ -n "$firecracker_version" ] || firecracker_version=$(get_from_kata_deps ".assets.hypervisor.firecracker.version")
-[ -n "$firecracker_version" ] || die "failed to get firecracker version"
+[[ -n "${firecracker_version}" ]] || firecracker_version=$(get_from_kata_deps ".assets.hypervisor.firecracker.version")
+[[ -n "${firecracker_version}" ]] || die "failed to get firecracker version"
 
 firecracker_tarball_url="${firecracker_url}/releases/download"
 
@@ -32,13 +35,13 @@ file_name="firecracker-${firecracker_version}-${arch}.tgz"
 download_url="${firecracker_tarball_url}/${firecracker_version}/${file_name}"
 
 info "Download firecracker version: ${firecracker_version} from ${download_url}"
-curl -o ${file_name} -L $download_url
+curl -o "${file_name}" -L "${download_url}"
 
 sha256sum="${file_name}.sha256.txt"
 sha256sum_url="${firecracker_tarball_url}/${firecracker_version}/${sha256sum}"
 
 info "Download firecracker ${sha256sum} from ${sha256sum_url}"
-curl -o ${sha256sum} -L $sha256sum_url
+curl -o "${sha256sum}" -L "${sha256sum_url}"
 
-sha256sum -c ${sha256sum}
-tar zxvf ${file_name}
+sha256sum -c "${sha256sum}"
+tar zxvf "${file_name}"