github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-08-29 12:54:10 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #6200 from gkurz/improve-appendFDs-doc

Browse Source 
runtime: Improve documentation of appendFDs
This commit is contained in:
GabyCT 2023-02-09 15:50:37 -06:00 committed by GitHub
commit 86501d5f6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/runtime/pkg/govmm/qemu/qemu.go
View File

@ -2631,8 +2631,9 @@ type Config struct {
qemuParams []string qemuParams []string
} }
// appendFDs append a list of file descriptors to the qemu configuration and // appendFDs appends a list of arbitrary file descriptors to the qemu configuration and
// returns a slice of offset file descriptors that will be seen by the qemu process. // returns a slice of consecutive file descriptors that will be seen by the qemu process.
// Please see the comment below for details.
func (config *Config) appendFDs(fds []*os.File) []int { func (config *Config) appendFDs(fds []*os.File) []int {
var fdInts []int var fdInts []int
@ -2644,6 +2645,10 @@ func (config *Config) appendFDs(fds []*os.File) []int {
// ExtraFiles specifies additional open files to be inherited by the // ExtraFiles specifies additional open files to be inherited by the
// new process. It does not include standard input, standard output, or // new process. It does not include standard input, standard output, or
// standard error. If non-nil, entry i becomes file descriptor 3+i. // standard error. If non-nil, entry i becomes file descriptor 3+i.
// This means that arbitrary file descriptors fd0, fd1... fdN passed in
// the array will be presented to the guest as consecutive descriptors
// 3, 4... N+3. The golang library internally relies on dup2() to do
// the renumbering.
for i := range fds { for i := range fds {
fdInts = append(fdInts, oldLen+3+i) fdInts = append(fdInts, oldLen+3+i)
} }