mirror of
https://github.com/kata-containers/kata-containers.git
synced 2026-05-01 05:14:56 +00:00
ci: install protobuf-compiler for runtime-rs build-checks
The `runtime-rs` component of `build-checks.yaml` declared `rust`
as its only dependency, but the runtime-rs build pulls in
`prost-build v0.8.0` (via `ttrpc-codegen` -> `containerd-shim-protos`,
and via the in-tree `hypervisor` crate), and `prost-build`'s build
script needs a `protoc` binary at compile time.
This worked on x86_64 and aarch64 only because `prost-build v0.8.0`
ships bundled `protoc` binaries for those targets. On s390x (and
ppc64le, when the matrix gets there) there is no bundled binary,
so the build fails with:
Failed to find the protoc binary. The PROTOC environment variable
is not set, there is no bundled protoc for this platform, and
protoc is not in the PATH
The reason this didn't show up in CI before is that `make test`
and `make check` for runtime-rs were wrapped in arch-specific
`ifeq` blocks in `src/runtime-rs/Makefile` that turned them into
no-ops on s390x/ppc64le/riscv64gc. The previous commit dropped
those gates so `make {test,check}` now actually run on every arch,
which exposes this latent CI gap.
Match what `agent`, `libs`, `agent-ctl`, `kata-ctl` and `genpolicy`
already declare and add `protobuf-compiler` to runtime-rs's needs.
The existing `Install protobuf-compiler` step in this workflow
already runs `sudo apt-get -y install protobuf-compiler`, which
the s390x/ppc64le runners support (those other components have
been using it on s390x for some time).
Made-with: Cursor
Signed-off-by: Fabiano Fidêncio <ffidencio@nvidia.com>
Made-with: Cursor
This commit is contained in:
Fabiano Fidêncio
@@ -144,7 +144,7 @@ mapping:
|
||||
- Static checks / build-checks / check (make check, genpolicy, src/tools/genpolicy, rust, protobuf-compiler, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make check, kata-ctl, src/tools/kata-ctl, rust, protobuf-compiler, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make check, libs, src/libs, rust, protobuf-compiler, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make check, runtime-rs, src/runtime-rs, rust, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make check, runtime-rs, src/runtime-rs, rust, protobuf-compiler, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make check, runtime, src/runtime, golang, XDG_RUNTIME_DIR, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make check, trace-forwarder, src/tools/trace-forwarder, rust, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make test, agent-ctl, src/tools/agent-ctl, rust, protobuf-compiler, clang, ubuntu-22.04)
|
||||
@@ -153,7 +153,7 @@ mapping:
|
||||
- Static checks / build-checks / check (make test, genpolicy, src/tools/genpolicy, rust, protobuf-compiler, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make test, kata-ctl, src/tools/kata-ctl, rust, protobuf-compiler, ubuntu-22.04)
|
||||
# - Static checks / build-checks / check (make test, libs, src/libs, rust, protobuf-compiler)
|
||||
- Static checks / build-checks / check (make test, runtime-rs, src/runtime-rs, rust, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make test, runtime-rs, src/runtime-rs, rust, protobuf-compiler, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make test, runtime, src/runtime, golang, XDG_RUNTIME_DIR, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make test, trace-forwarder, src/tools/trace-forwarder, rust, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make vendor, agent-ctl, src/tools/agent-ctl, rust, protobuf-compiler, clang, ubuntu-22.04)
|
||||
@@ -161,7 +161,7 @@ mapping:
|
||||
- Static checks / build-checks / check (make vendor, dragonball, src/dragonball, rust, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make vendor, genpolicy, src/tools/genpolicy, rust, protobuf-compiler, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make vendor, kata-ctl, src/tools/kata-ctl, rust, protobuf-compiler, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make vendor, runtime-rs, src/runtime-rs, rust, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make vendor, runtime-rs, src/runtime-rs, rust, protobuf-compiler, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make vendor, runtime, src/runtime, golang, XDG_RUNTIME_DIR, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (make vendor, trace-forwarder, src/tools/trace-forwarder, rust, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (sudo -E PATH="$PATH" make test, agent-ctl, src/tools/agent-ctl, rust, protobuf-compiler, c...
|
||||
@@ -170,7 +170,7 @@ mapping:
|
||||
- Static checks / build-checks / check (sudo -E PATH="$PATH" make test, genpolicy, src/tools/genpolicy, rust, protobuf-compiler, u...
|
||||
- Static checks / build-checks / check (sudo -E PATH="$PATH" make test, kata-ctl, src/tools/kata-ctl, rust, protobuf-compiler, ubu...
|
||||
- Static checks / build-checks / check (sudo -E PATH="$PATH" make test, libs, src/libs, rust, protobuf-compiler, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (sudo -E PATH="$PATH" make test, runtime-rs, src/runtime-rs, rust, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (sudo -E PATH="$PATH" make test, runtime-rs, src/runtime-rs, rust, protobuf-compiler, ubunt...
|
||||
- Static checks / build-checks / check (sudo -E PATH="$PATH" make test, runtime, src/runtime, golang, XDG_RUNTIME_DIR, ubuntu-22.04)
|
||||
- Static checks / build-checks / check (sudo -E PATH="$PATH" make test, trace-forwarder, src/tools/trace-forwarder, rust, ubuntu-2...
|
||||
- Static checks / build-checks-depending-on-kvm (runtime-rs)
|
||||
@@ -182,7 +182,7 @@ mapping:
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make check, dragonball, src/dragonball, rust, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make check, genpolicy, src/tools/genpolicy, rust, protobuf-compiler, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make check, kata-ctl, src/tools/kata-ctl, rust, protobuf-compiler, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make check, runtime-rs, src/runtime-rs, rust, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make check, runtime-rs, src/runtime-rs, rust, protobuf-compiler, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make check, runtime, src/runtime, golang, XDG_RUNTIME_DIR, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make check, trace-forwarder, src/tools/trace-forwarder, rust, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make check, agent-ctl, src/tools/agent-ctl, rust, protobuf-compiler, clang, ubuntu-24.04-s...
|
||||
@@ -190,7 +190,7 @@ mapping:
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make test, dragonball, src/dragonball, rust, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make test, genpolicy, src/tools/genpolicy, rust, protobuf-compiler, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make test, kata-ctl, src/tools/kata-ctl, rust, protobuf-compiler, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make test, runtime-rs, src/runtime-rs, rust, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make test, runtime-rs, src/runtime-rs, rust, protobuf-compiler, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make test, runtime, src/runtime, golang, XDG_RUNTIME_DIR, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make test, trace-forwarder, src/tools/trace-forwarder, rust, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make vendor, agent-ctl, src/tools/agent-ctl, rust, protobuf-compiler, clang, ubuntu-24.04-...
|
||||
@@ -198,14 +198,14 @@ mapping:
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make vendor, dragonball, src/dragonball, rust, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make vendor, genpolicy, src/tools/genpolicy, rust, protobuf-compiler, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make vendor, kata-ctl, src/tools/kata-ctl, rust, protobuf-compiler, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make vendor, runtime-rs, src/runtime-rs, rust, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make vendor, runtime-rs, src/runtime-rs, rust, protobuf-compiler, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make vendor, runtime, src/runtime, golang, XDG_RUNTIME_DIR, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (make vendor, trace-forwarder, src/tools/trace-forwarder, rust, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (sudo -E PATH="$PATH" make test, agent-ctl, src/tools/agent-ctl, rust, protobuf-compiler, c...
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (sudo -E PATH="$PATH" make test, dragonball, src/dragonball, rust, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (sudo -E PATH="$PATH" make test, genpolicy, src/tools/genpolicy, rust, protobuf-compiler, u...
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (sudo -E PATH="$PATH" make test, kata-ctl, src/tools/kata-ctl, rust, protobuf-compiler, ubu...
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (sudo -E PATH="$PATH" make test, runtime-rs, src/runtime-rs, rust, ubuntu-24.04-s390x)
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (sudo -E PATH="$PATH" make test, runtime-rs, src/runtime-rs, rust, protobuf-compiler, ubunt...
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (sudo -E PATH="$PATH" make test, runtime, src/runtime, golang, XDG_RUNTIME_DIR, ubuntu-24.0...
|
||||
- Static checks self-hosted / build-checks (ubuntu-24.04-s390x) / check (sudo -E PATH="$PATH" make test, trace-forwarder, src/tools/trace-forwarder, rust, ubuntu-2...
|
||||
required-labels:
|
||||
|
||||
Reference in New Issue
Block a user