Merge pull request #6208 from joannejchen/fix-naming-conventions

improvement: Fix naming conventions for span name and log subsystem
This commit is contained in:
Bin Liu
2023-02-07 13:43:37 +08:00
committed by GitHub

View File

@@ -42,16 +42,16 @@ func NewFilesystemShare(s *Sandbox) (FilesystemSharer, error) {
}, nil }, nil
} }
// Logger returns a logrus logger appropriate for logging Filesystem sharing messages // Logger returns a logrus logger appropriate for logging filesystem sharing messages
func (f *FilesystemShare) Logger() *logrus.Entry { func (f *FilesystemShare) Logger() *logrus.Entry {
return virtLog.WithFields(logrus.Fields{ return virtLog.WithFields(logrus.Fields{
"subsystem": "filesystem share", "subsystem": "fs_share",
"sandbox": f.sandbox.ID(), "sandbox": f.sandbox.ID(),
}) })
} }
func (f *FilesystemShare) prepareBindMounts(ctx context.Context) error { func (f *FilesystemShare) prepareBindMounts(ctx context.Context) error {
span, ctx := katatrace.Trace(ctx, f.Logger(), "setupBindMounts", fsShareTracingTags) span, ctx := katatrace.Trace(ctx, f.Logger(), "prepareBindMounts", fsShareTracingTags)
defer span.End() defer span.End()
var err error var err error