From 8cb3abf771933faa2c5832fe492164d5146e7057 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Tue, 21 Apr 2026 18:15:35 +0200 Subject: [PATCH] tools: Fix shellcheck issues in build.sh MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Address shellcheck warnings including proper variable quoting, use of [[ ]] over [ ], declaring and assigning variables separately, and adding appropriate shellcheck disable directives where needed. Signed-off-by: Fabiano Fidêncio Made-with: Cursor --- tools/packaging/static-build/busybox/build.sh | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/packaging/static-build/busybox/build.sh b/tools/packaging/static-build/busybox/build.sh index 9100b315e7..0b2fe9169c 100755 --- a/tools/packaging/static-build/busybox/build.sh +++ b/tools/packaging/static-build/busybox/build.sh @@ -16,6 +16,7 @@ source "${script_dir}/../../scripts/lib.sh" readonly busybox_builder="${script_dir}/build-static-busybox.sh" +# shellcheck disable=SC2154 readonly busybox_builddir="${repo_root_dir}/build/busybox/builddir" busybox_version="$(get_from_kata_deps ".externals.busybox.version")" @@ -26,10 +27,12 @@ readonly BUSYBOX_URL="${busybox_url}" container_image="${BUSYBOX_CONTAINER_BUILDER:-$(get_busybox_image_name)}" -[ "${CROSS_BUILD}" == "true" ] && container_image="${container_image}-cross-build" +# shellcheck disable=SC2154 +[[ "${CROSS_BUILD}" == "true" ]] && container_image="${container_image}-cross-build" +# shellcheck disable=SC2154,SC2086 docker pull "${container_image}" || \ - (docker $BUILDX build $PLATFORM \ + (docker ${BUILDX} build ${PLATFORM} \ -t "${container_image}" "${script_dir}" \ # No-op unless PUSH_TO_REGISTRY is exported as "yes" push_to_registry "${container_image}")