diff --git a/src/runtime/virtcontainers/acrn.go b/src/runtime/virtcontainers/acrn.go index bf6f55410e..a8c5b530f6 100644 --- a/src/runtime/virtcontainers/acrn.go +++ b/src/runtime/virtcontainers/acrn.go @@ -156,8 +156,7 @@ func (a *Acrn) kernelParameters() string { // Adds all capabilities supported by Acrn implementation of hypervisor interface func (a *Acrn) capabilities(ctx context.Context) types.Capabilities { - span, _ := katatrace.Trace(ctx, a.Logger(), "capabilities", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, _ := katatrace.Trace(ctx, a.Logger(), "capabilities", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() return a.arch.capabilities() @@ -282,8 +281,7 @@ func (a *Acrn) buildDevices(ctx context.Context, imagePath string) ([]Device, er // setup sets the Acrn structure up. func (a *Acrn) setup(ctx context.Context, id string, hypervisorConfig *HypervisorConfig) error { - span, _ := katatrace.Trace(ctx, a.Logger(), "setup", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, _ := katatrace.Trace(ctx, a.Logger(), "setup", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() err := hypervisorConfig.valid() @@ -326,8 +324,7 @@ func (a *Acrn) setup(ctx context.Context, id string, hypervisorConfig *Hyperviso } func (a *Acrn) createDummyVirtioBlkDev(ctx context.Context, devices []Device) ([]Device, error) { - span, _ := katatrace.Trace(ctx, a.Logger(), "createDummyVirtioBlkDev", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, _ := katatrace.Trace(ctx, a.Logger(), "createDummyVirtioBlkDev", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() // Since acrn doesn't support hot-plug, dummy virtio-blk @@ -350,8 +347,7 @@ func (a *Acrn) createSandbox(ctx context.Context, id string, networkNS NetworkNa // Save the tracing context a.ctx = ctx - span, ctx := katatrace.Trace(ctx, a.Logger(), "createSandbox", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, ctx := katatrace.Trace(ctx, a.Logger(), "createSandbox", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() if err := a.setup(ctx, id, hypervisorConfig); err != nil { @@ -416,8 +412,7 @@ func (a *Acrn) createSandbox(ctx context.Context, id string, networkNS NetworkNa // startSandbox will start the Sandbox's VM. func (a *Acrn) startSandbox(ctx context.Context, timeoutSecs int) error { - span, ctx := katatrace.Trace(ctx, a.Logger(), "startSandbox", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, ctx := katatrace.Trace(ctx, a.Logger(), "startSandbox", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() if a.config.Debug { @@ -463,8 +458,7 @@ func (a *Acrn) startSandbox(ctx context.Context, timeoutSecs int) error { // waitSandbox will wait for the Sandbox's VM to be up and running. func (a *Acrn) waitSandbox(ctx context.Context, timeoutSecs int) error { - span, _ := katatrace.Trace(ctx, a.Logger(), "waitSandbox", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, _ := katatrace.Trace(ctx, a.Logger(), "waitSandbox", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() if timeoutSecs < 0 { @@ -478,8 +472,7 @@ func (a *Acrn) waitSandbox(ctx context.Context, timeoutSecs int) error { // stopSandbox will stop the Sandbox's VM. func (a *Acrn) stopSandbox(ctx context.Context, waitOnly bool) (err error) { - span, _ := katatrace.Trace(ctx, a.Logger(), "stopSandbox", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, _ := katatrace.Trace(ctx, a.Logger(), "stopSandbox", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() a.Logger().Info("Stopping acrn VM") @@ -551,8 +544,7 @@ func (a *Acrn) updateBlockDevice(drive *config.BlockDrive) error { } func (a *Acrn) hotplugAddDevice(ctx context.Context, devInfo interface{}, devType deviceType) (interface{}, error) { - span, _ := katatrace.Trace(ctx, a.Logger(), "hotplugAddDevice", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, _ := katatrace.Trace(ctx, a.Logger(), "hotplugAddDevice", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() switch devType { @@ -566,8 +558,7 @@ func (a *Acrn) hotplugAddDevice(ctx context.Context, devInfo interface{}, devTyp } func (a *Acrn) hotplugRemoveDevice(ctx context.Context, devInfo interface{}, devType deviceType) (interface{}, error) { - span, _ := katatrace.Trace(ctx, a.Logger(), "hotplugRemoveDevice", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, _ := katatrace.Trace(ctx, a.Logger(), "hotplugRemoveDevice", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() // Not supported. return success @@ -576,8 +567,7 @@ func (a *Acrn) hotplugRemoveDevice(ctx context.Context, devInfo interface{}, dev } func (a *Acrn) pauseSandbox(ctx context.Context) error { - span, _ := katatrace.Trace(ctx, a.Logger(), "pauseSandbox", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, _ := katatrace.Trace(ctx, a.Logger(), "pauseSandbox", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() // Not supported. return success @@ -586,8 +576,7 @@ func (a *Acrn) pauseSandbox(ctx context.Context) error { } func (a *Acrn) resumeSandbox(ctx context.Context) error { - span, _ := katatrace.Trace(ctx, a.Logger(), "resumeSandbox", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, _ := katatrace.Trace(ctx, a.Logger(), "resumeSandbox", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() // Not supported. return success @@ -598,8 +587,7 @@ func (a *Acrn) resumeSandbox(ctx context.Context) error { // addDevice will add extra devices to acrn command line. func (a *Acrn) addDevice(ctx context.Context, devInfo interface{}, devType deviceType) error { var err error - span, _ := katatrace.Trace(ctx, a.Logger(), "addDevice", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, _ := katatrace.Trace(ctx, a.Logger(), "addDevice", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() switch v := devInfo.(type) { @@ -632,8 +620,7 @@ func (a *Acrn) addDevice(ctx context.Context, devInfo interface{}, devType devic // getSandboxConsole builds the path of the console where we can read // logs coming from the sandbox. func (a *Acrn) getSandboxConsole(ctx context.Context, id string) (string, string, error) { - span, _ := katatrace.Trace(ctx, a.Logger(), "getSandboxConsole", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, _ := katatrace.Trace(ctx, a.Logger(), "getSandboxConsole", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() consoleURL, err := utils.BuildSocketPath(a.store.RunVMStoragePath(), id, acrnConsoleSocket) @@ -653,16 +640,14 @@ func (a *Acrn) saveSandbox() error { } func (a *Acrn) disconnect(ctx context.Context) { - span, _ := katatrace.Trace(ctx, a.Logger(), "disconnect", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, _ := katatrace.Trace(ctx, a.Logger(), "disconnect", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() // Not supported. } func (a *Acrn) getThreadIDs(ctx context.Context) (vcpuThreadIDs, error) { - span, _ := katatrace.Trace(ctx, a.Logger(), "getThreadIDs", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, _ := katatrace.Trace(ctx, a.Logger(), "getThreadIDs", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() // Not supported. return success @@ -680,8 +665,7 @@ func (a *Acrn) resizeVCPUs(ctx context.Context, reqVCPUs uint32) (currentVCPUs u } func (a *Acrn) cleanup(ctx context.Context) error { - span, _ := katatrace.Trace(ctx, a.Logger(), "cleanup", acrnTracingTags) - katatrace.AddTag(span, "sandbox_id", a.id) + span, _ := katatrace.Trace(ctx, a.Logger(), "cleanup", acrnTracingTags, map[string]string{"sandbox_id": a.id}) defer span.End() return nil diff --git a/src/runtime/virtcontainers/clh.go b/src/runtime/virtcontainers/clh.go index 294f36b6c5..e419770bb4 100644 --- a/src/runtime/virtcontainers/clh.go +++ b/src/runtime/virtcontainers/clh.go @@ -152,8 +152,7 @@ var clhDebugKernelParams = []Param{ func (clh *cloudHypervisor) createSandbox(ctx context.Context, id string, networkNS NetworkNamespace, hypervisorConfig *HypervisorConfig) error { clh.ctx = ctx - span, newCtx := katatrace.Trace(clh.ctx, clh.Logger(), "createSandbox", clhTracingTags) - katatrace.AddTag(span, "sandbox_id", clh.id) + span, newCtx := katatrace.Trace(clh.ctx, clh.Logger(), "createSandbox", clhTracingTags, map[string]string{"sandbox_id": clh.id}) clh.ctx = newCtx defer span.End() @@ -318,8 +317,7 @@ func (clh *cloudHypervisor) createSandbox(ctx context.Context, id string, networ // startSandbox will start the VMM and boot the virtual machine for the given sandbox. func (clh *cloudHypervisor) startSandbox(ctx context.Context, timeout int) error { - span, _ := katatrace.Trace(ctx, clh.Logger(), "startSandbox", clhTracingTags) - katatrace.AddTag(span, "sandbox_id", clh.id) + span, _ := katatrace.Trace(ctx, clh.Logger(), "startSandbox", clhTracingTags, map[string]string{"sandbox_id": clh.id}) defer span.End() ctx, cancel := context.WithTimeout(context.Background(), clhAPITimeout*time.Second) @@ -482,7 +480,7 @@ func (clh *cloudHypervisor) hotPlugVFIODevice(device config.VFIODev) error { } func (clh *cloudHypervisor) hotplugAddDevice(ctx context.Context, devInfo interface{}, devType deviceType) (interface{}, error) { - span, _ := katatrace.Trace(ctx, clh.Logger(), "hotplugAddDevice", clhTracingTags) + span, _ := katatrace.Trace(ctx, clh.Logger(), "hotplugAddDevice", clhTracingTags, map[string]string{"sandbox_id": clh.id}) defer span.End() switch devType { @@ -499,8 +497,7 @@ func (clh *cloudHypervisor) hotplugAddDevice(ctx context.Context, devInfo interf } func (clh *cloudHypervisor) hotplugRemoveDevice(ctx context.Context, devInfo interface{}, devType deviceType) (interface{}, error) { - span, _ := katatrace.Trace(ctx, clh.Logger(), "hotplugRemoveDevice", clhTracingTags) - katatrace.AddTag(span, "sandbox_id", clh.id) + span, _ := katatrace.Trace(ctx, clh.Logger(), "hotplugRemoveDevice", clhTracingTags, map[string]string{"sandbox_id": clh.id}) defer span.End() var deviceID string @@ -660,8 +657,7 @@ func (clh *cloudHypervisor) resumeSandbox(ctx context.Context) error { // stopSandbox will stop the Sandbox's VM. func (clh *cloudHypervisor) stopSandbox(ctx context.Context, waitOnly bool) (err error) { - span, _ := katatrace.Trace(ctx, clh.Logger(), "stopSandbox", clhTracingTags) - katatrace.AddTag(span, "sandbox_id", clh.id) + span, _ := katatrace.Trace(ctx, clh.Logger(), "stopSandbox", clhTracingTags, map[string]string{"sandbox_id": clh.id}) defer span.End() clh.Logger().WithField("function", "stopSandbox").Info("Stop Sandbox") return clh.terminate(ctx, waitOnly) @@ -711,8 +707,7 @@ func (clh *cloudHypervisor) getVirtioFsPid() *int { } func (clh *cloudHypervisor) addDevice(ctx context.Context, devInfo interface{}, devType deviceType) error { - span, _ := katatrace.Trace(ctx, clh.Logger(), "addDevice", clhTracingTags) - katatrace.AddTag(span, "sandbox_id", clh.id) + span, _ := katatrace.Trace(ctx, clh.Logger(), "addDevice", clhTracingTags, map[string]string{"sandbox_id": clh.id}) defer span.End() var err error @@ -746,8 +741,7 @@ func (clh *cloudHypervisor) Logger() *log.Entry { // Adds all capabilities supported by cloudHypervisor implementation of hypervisor interface func (clh *cloudHypervisor) capabilities(ctx context.Context) types.Capabilities { - span, _ := katatrace.Trace(ctx, clh.Logger(), "capabilities", clhTracingTags) - katatrace.AddTag(span, "sandbox_id", clh.id) + span, _ := katatrace.Trace(ctx, clh.Logger(), "capabilities", clhTracingTags, map[string]string{"sandbox_id": clh.id}) defer span.End() clh.Logger().WithField("function", "capabilities").Info("get Capabilities") @@ -758,8 +752,7 @@ func (clh *cloudHypervisor) capabilities(ctx context.Context) types.Capabilities } func (clh *cloudHypervisor) terminate(ctx context.Context, waitOnly bool) (err error) { - span, _ := katatrace.Trace(ctx, clh.Logger(), "terminate", clhTracingTags) - katatrace.AddTag(span, "sandbox_id", clh.id) + span, _ := katatrace.Trace(ctx, clh.Logger(), "terminate", clhTracingTags, map[string]string{"sandbox_id": clh.id}) defer span.End() pid := clh.state.PID diff --git a/src/runtime/virtcontainers/container.go b/src/runtime/virtcontainers/container.go index 0344b0f9e1..8525aa105a 100644 --- a/src/runtime/virtcontainers/container.go +++ b/src/runtime/virtcontainers/container.go @@ -616,15 +616,12 @@ func (c *Container) mountSharedDirMounts(ctx context.Context, sharedDirMounts, i } func (c *Container) unmountHostMounts(ctx context.Context) error { - span, ctx := katatrace.Trace(ctx, c.Logger(), "unmountHostMounts", containerTracingTags) - katatrace.AddTag(span, "container_id", c.id) + span, ctx := katatrace.Trace(ctx, c.Logger(), "unmountHostMounts", containerTracingTags, map[string]string{"container_id": c.id}) defer span.End() for _, m := range c.mounts { if m.HostPath != "" { - span, _ := katatrace.Trace(ctx, c.Logger(), "unmount", containerTracingTags) - katatrace.AddTag(span, "container_id", c.id) - katatrace.AddTag(span, "host-path", m.HostPath) + span, _ := katatrace.Trace(ctx, c.Logger(), "unmount", containerTracingTags, map[string]string{"container_id": c.id, "host-path": m.HostPath}) if err := syscall.Unmount(m.HostPath, syscall.MNT_DETACH|UmountNoFollow); err != nil { c.Logger().WithFields(logrus.Fields{ @@ -752,9 +749,7 @@ func (c *Container) initConfigResourcesMemory() { // newContainer creates a Container structure from a sandbox and a container configuration. func newContainer(ctx context.Context, sandbox *Sandbox, contConfig *ContainerConfig) (*Container, error) { - span, ctx := katatrace.Trace(ctx, sandbox.Logger(), "newContainer", containerTracingTags) - katatrace.AddTag(span, "sandbox_id", sandbox.id) - katatrace.AddTag(span, "container_id", contConfig.ID) + span, ctx := katatrace.Trace(ctx, sandbox.Logger(), "newContainer", containerTracingTags, map[string]string{"container_id": contConfig.ID, "sandbox_id": sandbox.id}) defer span.End() if !contConfig.valid() { @@ -1050,8 +1045,7 @@ func (c *Container) start(ctx context.Context) error { } func (c *Container) stop(ctx context.Context, force bool) error { - span, ctx := katatrace.Trace(ctx, c.Logger(), "stop", containerTracingTags) - katatrace.AddTag(span, "container_id", c.id) + span, ctx := katatrace.Trace(ctx, c.Logger(), "stop", containerTracingTags, map[string]string{"container_id": c.id}) defer span.End() // In case the container status has been updated implicitly because diff --git a/src/runtime/virtcontainers/fc.go b/src/runtime/virtcontainers/fc.go index 7b5ee3e490..f3002ee44e 100644 --- a/src/runtime/virtcontainers/fc.go +++ b/src/runtime/virtcontainers/fc.go @@ -191,8 +191,7 @@ func (fc *firecracker) truncateID(id string) string { func (fc *firecracker) createSandbox(ctx context.Context, id string, networkNS NetworkNamespace, hypervisorConfig *HypervisorConfig) error { fc.ctx = ctx - span, _ := katatrace.Trace(ctx, fc.Logger(), "createSandbox", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "createSandbox", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() //TODO: check validity of the hypervisor config provided @@ -235,8 +234,7 @@ func (fc *firecracker) createSandbox(ctx context.Context, id string, networkNS N } func (fc *firecracker) newFireClient(ctx context.Context) *client.Firecracker { - span, _ := katatrace.Trace(ctx, fc.Logger(), "newFireClient", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "newFireClient", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() httpClient := client.NewHTTPClient(strfmt.NewFormats()) @@ -314,8 +312,7 @@ func (fc *firecracker) checkVersion(version string) error { // waitVMMRunning will wait for timeout seconds for the VMM to be up and running. func (fc *firecracker) waitVMMRunning(ctx context.Context, timeout int) error { - span, _ := katatrace.Trace(ctx, fc.Logger(), "wait VMM to be running", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "wait VMM to be running", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() if timeout < 0 { @@ -337,8 +334,7 @@ func (fc *firecracker) waitVMMRunning(ctx context.Context, timeout int) error { } func (fc *firecracker) fcInit(ctx context.Context, timeout int) error { - span, _ := katatrace.Trace(ctx, fc.Logger(), "fcInit", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "fcInit", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() var err error @@ -413,8 +409,7 @@ func (fc *firecracker) fcInit(ctx context.Context, timeout int) error { } func (fc *firecracker) fcEnd(ctx context.Context, waitOnly bool) (err error) { - span, _ := katatrace.Trace(ctx, fc.Logger(), "fcEnd", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "fcEnd", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() fc.Logger().Info("Stopping firecracker VM") @@ -441,8 +436,7 @@ func (fc *firecracker) fcEnd(ctx context.Context, waitOnly bool) (err error) { } func (fc *firecracker) client(ctx context.Context) *client.Firecracker { - span, _ := katatrace.Trace(ctx, fc.Logger(), "client", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "client", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() if fc.connection == nil { @@ -509,8 +503,7 @@ func (fc *firecracker) fcJailResource(src, dst string) (string, error) { } func (fc *firecracker) fcSetBootSource(ctx context.Context, path, params string) error { - span, _ := katatrace.Trace(ctx, fc.Logger(), "fcSetBootSource", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "fcSetBootSource", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() fc.Logger().WithFields(logrus.Fields{"kernel-path": path, "kernel-params": params}).Debug("fcSetBootSource") @@ -531,8 +524,7 @@ func (fc *firecracker) fcSetBootSource(ctx context.Context, path, params string) } func (fc *firecracker) fcSetVMRootfs(ctx context.Context, path string) error { - span, _ := katatrace.Trace(ctx, fc.Logger(), "fcSetVMRootfs", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "fcSetVMRootfs", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() jailedRootfs, err := fc.fcJailResource(path, fcRootfs) @@ -559,8 +551,7 @@ func (fc *firecracker) fcSetVMRootfs(ctx context.Context, path string) error { } func (fc *firecracker) fcSetVMBaseConfig(ctx context.Context, mem int64, vcpus int64, htEnabled bool) { - span, _ := katatrace.Trace(ctx, fc.Logger(), "fcSetVMBaseConfig", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "fcSetVMBaseConfig", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() fc.Logger().WithFields(logrus.Fields{"mem": mem, "vcpus": vcpus, @@ -576,8 +567,7 @@ func (fc *firecracker) fcSetVMBaseConfig(ctx context.Context, mem int64, vcpus i } func (fc *firecracker) fcSetLogger(ctx context.Context) error { - span, _ := katatrace.Trace(ctx, fc.Logger(), "fcSetLogger", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "fcSetLogger", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() fcLogLevel := "Error" @@ -600,8 +590,7 @@ func (fc *firecracker) fcSetLogger(ctx context.Context) error { } func (fc *firecracker) fcSetMetrics(ctx context.Context) error { - span, _ := katatrace.Trace(ctx, fc.Logger(), "fcSetMetrics", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "fcSetMetrics", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() // listen to metrics file and transfer error info @@ -756,8 +745,7 @@ func (fc *firecracker) fcInitConfiguration(ctx context.Context) error { // In the context of firecracker, this will start the hypervisor, // for configuration, but not yet start the actual virtual machine func (fc *firecracker) startSandbox(ctx context.Context, timeout int) error { - span, _ := katatrace.Trace(ctx, fc.Logger(), "startSandbox", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "startSandbox", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() if err := fc.fcInitConfiguration(ctx); err != nil { @@ -809,8 +797,7 @@ func fcDriveIndexToID(i int) string { } func (fc *firecracker) createDiskPool(ctx context.Context) error { - span, _ := katatrace.Trace(ctx, fc.Logger(), "createDiskPool", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "createDiskPool", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() for i := 0; i < fcDiskPoolSize; i++ { @@ -848,8 +835,7 @@ func (fc *firecracker) umountResource(jailedPath string) { // cleanup all jail artifacts func (fc *firecracker) cleanupJail(ctx context.Context) { - span, _ := katatrace.Trace(ctx, fc.Logger(), "cleanupJail", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "cleanupJail", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() fc.umountResource(fcKernel) @@ -872,8 +858,7 @@ func (fc *firecracker) cleanupJail(ctx context.Context) { // stopSandbox will stop the Sandbox's VM. func (fc *firecracker) stopSandbox(ctx context.Context, waitOnly bool) (err error) { - span, _ := katatrace.Trace(ctx, fc.Logger(), "stopSandbox", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "stopSandbox", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() return fc.fcEnd(ctx, waitOnly) @@ -892,8 +877,7 @@ func (fc *firecracker) resumeSandbox(ctx context.Context) error { } func (fc *firecracker) fcAddVsock(ctx context.Context, hvs types.HybridVSock) { - span, _ := katatrace.Trace(ctx, fc.Logger(), "fcAddVsock", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "fcAddVsock", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() udsPath := hvs.UdsPath @@ -913,8 +897,7 @@ func (fc *firecracker) fcAddVsock(ctx context.Context, hvs types.HybridVSock) { } func (fc *firecracker) fcAddNetDevice(ctx context.Context, endpoint Endpoint) { - span, _ := katatrace.Trace(ctx, fc.Logger(), "fcAddNetDevice", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "fcAddNetDevice", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() ifaceID := endpoint.Name() @@ -970,8 +953,7 @@ func (fc *firecracker) fcAddNetDevice(ctx context.Context, endpoint Endpoint) { } func (fc *firecracker) fcAddBlockDrive(ctx context.Context, drive config.BlockDrive) error { - span, _ := katatrace.Trace(ctx, fc.Logger(), "fcAddBlockDrive", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "fcAddBlockDrive", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() driveID := drive.ID @@ -997,8 +979,7 @@ func (fc *firecracker) fcAddBlockDrive(ctx context.Context, drive config.BlockDr // Firecracker supports replacing the host drive used once the VM has booted up func (fc *firecracker) fcUpdateBlockDrive(ctx context.Context, path, id string) error { - span, _ := katatrace.Trace(ctx, fc.Logger(), "fcUpdateBlockDrive", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "fcUpdateBlockDrive", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() // Use the global block index as an index into the pool of the devices @@ -1022,8 +1003,7 @@ func (fc *firecracker) fcUpdateBlockDrive(ctx context.Context, path, id string) // addDevice will add extra devices to firecracker. Limited to configure before the // virtual machine starts. Devices include drivers and network interfaces only. func (fc *firecracker) addDevice(ctx context.Context, devInfo interface{}, devType deviceType) error { - span, _ := katatrace.Trace(ctx, fc.Logger(), "addDevice", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "addDevice", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() fc.state.RLock() @@ -1093,8 +1073,7 @@ func (fc *firecracker) hotplugBlockDevice(ctx context.Context, drive config.Bloc // hotplugAddDevice supported in Firecracker VMM func (fc *firecracker) hotplugAddDevice(ctx context.Context, devInfo interface{}, devType deviceType) (interface{}, error) { - span, _ := katatrace.Trace(ctx, fc.Logger(), "hotplugAddDevice", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "hotplugAddDevice", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() switch devType { @@ -1110,8 +1089,7 @@ func (fc *firecracker) hotplugAddDevice(ctx context.Context, devInfo interface{} // hotplugRemoveDevice supported in Firecracker VMM func (fc *firecracker) hotplugRemoveDevice(ctx context.Context, devInfo interface{}, devType deviceType) (interface{}, error) { - span, _ := katatrace.Trace(ctx, fc.Logger(), "hotplugRemoveDevice", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "hotplugRemoveDevice", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() switch devType { @@ -1144,8 +1122,7 @@ func (fc *firecracker) disconnect(ctx context.Context) { // Adds all capabilities supported by firecracker implementation of hypervisor interface func (fc *firecracker) capabilities(ctx context.Context) types.Capabilities { - span, _ := katatrace.Trace(ctx, fc.Logger(), "capabilities", fcTracingTags) - katatrace.AddTag(span, "sandbox_id", fc.id) + span, _ := katatrace.Trace(ctx, fc.Logger(), "capabilities", fcTracingTags, map[string]string{"sandbox_id": fc.id}) defer span.End() var caps types.Capabilities caps.SetBlockDeviceHotplugSupport() diff --git a/src/runtime/virtcontainers/qemu.go b/src/runtime/virtcontainers/qemu.go index c0bd9884e3..63454cd456 100644 --- a/src/runtime/virtcontainers/qemu.go +++ b/src/runtime/virtcontainers/qemu.go @@ -192,8 +192,7 @@ func (q *qemu) kernelParameters() string { // Adds all capabilities supported by qemu implementation of hypervisor interface func (q *qemu) capabilities(ctx context.Context) types.Capabilities { - span, _ := katatrace.Trace(ctx, q.Logger(), "capabilities", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) + span, _ := katatrace.Trace(ctx, q.Logger(), "capabilities", qemuTracingTags, map[string]string{"sandbox_id": q.id}) defer span.End() return q.arch.capabilities() @@ -223,8 +222,7 @@ func (q *qemu) qemuPath() (string, error) { // setup sets the Qemu structure up. func (q *qemu) setup(ctx context.Context, id string, hypervisorConfig *HypervisorConfig) error { - span, _ := katatrace.Trace(ctx, q.Logger(), "setup", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) + span, _ := katatrace.Trace(ctx, q.Logger(), "setup", qemuTracingTags, map[string]string{"sandbox_id": q.id}) defer span.End() err := hypervisorConfig.valid() @@ -467,8 +465,7 @@ func (q *qemu) createSandbox(ctx context.Context, id string, networkNS NetworkNa // Save the tracing context q.ctx = ctx - span, ctx := katatrace.Trace(ctx, q.Logger(), "createSandbox", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) + span, ctx := katatrace.Trace(ctx, q.Logger(), "createSandbox", qemuTracingTags, map[string]string{"sandbox_id": q.id}) defer span.End() if err := q.setup(ctx, id, hypervisorConfig); err != nil { @@ -753,8 +750,7 @@ func (q *qemu) setupVirtioMem(ctx context.Context) error { // startSandbox will start the Sandbox's VM. func (q *qemu) startSandbox(ctx context.Context, timeout int) error { - span, ctx := katatrace.Trace(ctx, q.Logger(), "startSandbox", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) + span, ctx := katatrace.Trace(ctx, q.Logger(), "startSandbox", qemuTracingTags, map[string]string{"sandbox_id": q.id}) defer span.End() if q.config.Debug { @@ -872,8 +868,7 @@ func (q *qemu) bootFromTemplate() error { // waitSandbox will wait for the Sandbox's VM to be up and running. func (q *qemu) waitSandbox(ctx context.Context, timeout int) error { - span, _ := katatrace.Trace(ctx, q.Logger(), "waitSandbox", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) + span, _ := katatrace.Trace(ctx, q.Logger(), "waitSandbox", qemuTracingTags, map[string]string{"sandbox_id": q.id}) defer span.End() if timeout < 0 { @@ -924,8 +919,7 @@ func (q *qemu) waitSandbox(ctx context.Context, timeout int) error { // stopSandbox will stop the Sandbox's VM. func (q *qemu) stopSandbox(ctx context.Context, waitOnly bool) error { - span, _ := katatrace.Trace(ctx, q.Logger(), "stopSandbox", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) + span, _ := katatrace.Trace(ctx, q.Logger(), "stopSandbox", qemuTracingTags, map[string]string{"sandbox_id": q.id}) defer span.End() q.Logger().Info("Stopping Sandbox") @@ -1017,8 +1011,7 @@ func (q *qemu) cleanupVM() error { } func (q *qemu) togglePauseSandbox(ctx context.Context, pause bool) error { - span, _ := katatrace.Trace(ctx, q.Logger(), "togglePauseSandbox", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) + span, _ := katatrace.Trace(ctx, q.Logger(), "togglePauseSandbox", qemuTracingTags, map[string]string{"sandbox_id": q.id}) defer span.End() if err := q.qmpSetup(); err != nil { @@ -1623,10 +1616,9 @@ func (q *qemu) hotplugDevice(ctx context.Context, devInfo interface{}, devType d } func (q *qemu) hotplugAddDevice(ctx context.Context, devInfo interface{}, devType deviceType) (interface{}, error) { - span, ctx := katatrace.Trace(ctx, q.Logger(), "hotplugAddDevice", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) - defer span.End() + span, ctx := katatrace.Trace(ctx, q.Logger(), "hotplugAddDevice", qemuTracingTags, map[string]string{"sandbox_id": q.id}) katatrace.AddTag(span, "device", devInfo) + defer span.End() data, err := q.hotplugDevice(ctx, devInfo, devType, addDevice) if err != nil { @@ -1637,10 +1629,9 @@ func (q *qemu) hotplugAddDevice(ctx context.Context, devInfo interface{}, devTyp } func (q *qemu) hotplugRemoveDevice(ctx context.Context, devInfo interface{}, devType deviceType) (interface{}, error) { - span, ctx := katatrace.Trace(ctx, q.Logger(), "hotplugRemoveDevice", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) - defer span.End() + span, ctx := katatrace.Trace(ctx, q.Logger(), "hotplugRemoveDevice", qemuTracingTags, map[string]string{"sandbox_id": q.id}) katatrace.AddTag(span, "device", devInfo) + defer span.End() data, err := q.hotplugDevice(ctx, devInfo, devType, removeDevice) if err != nil { @@ -1851,16 +1842,14 @@ func (q *qemu) hotplugAddMemory(memDev *memoryDevice) (int, error) { } func (q *qemu) pauseSandbox(ctx context.Context) error { - span, ctx := katatrace.Trace(ctx, q.Logger(), "pauseSandbox", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) + span, ctx := katatrace.Trace(ctx, q.Logger(), "pauseSandbox", qemuTracingTags, map[string]string{"sandbox_id": q.id}) defer span.End() return q.togglePauseSandbox(ctx, true) } func (q *qemu) resumeSandbox(ctx context.Context) error { - span, ctx := katatrace.Trace(ctx, q.Logger(), "resumeSandbox", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) + span, ctx := katatrace.Trace(ctx, q.Logger(), "resumeSandbox", qemuTracingTags, map[string]string{"sandbox_id": q.id}) defer span.End() return q.togglePauseSandbox(ctx, false) @@ -1869,10 +1858,9 @@ func (q *qemu) resumeSandbox(ctx context.Context) error { // addDevice will add extra devices to Qemu command line. func (q *qemu) addDevice(ctx context.Context, devInfo interface{}, devType deviceType) error { var err error - span, _ := katatrace.Trace(ctx, q.Logger(), "addDevice", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) - defer span.End() + span, _ := katatrace.Trace(ctx, q.Logger(), "addDevice", qemuTracingTags, map[string]string{"sandbox_id": q.id}) katatrace.AddTag(span, "device", devInfo) + defer span.End() switch v := devInfo.(type) { case types.Volume: @@ -1929,8 +1917,7 @@ func (q *qemu) addDevice(ctx context.Context, devInfo interface{}, devType devic // getSandboxConsole builds the path of the console where we can read // logs coming from the sandbox. func (q *qemu) getSandboxConsole(ctx context.Context, id string) (string, string, error) { - span, _ := katatrace.Trace(ctx, q.Logger(), "getSandboxConsole", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) + span, _ := katatrace.Trace(ctx, q.Logger(), "getSandboxConsole", qemuTracingTags, map[string]string{"sandbox_id": q.id}) defer span.End() consoleURL, err := utils.BuildSocketPath(q.store.RunVMStoragePath(), id, consoleSocket) @@ -1995,8 +1982,7 @@ func (q *qemu) waitMigration() error { } func (q *qemu) disconnect(ctx context.Context) { - span, _ := katatrace.Trace(ctx, q.Logger(), "disconnect", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) + span, _ := katatrace.Trace(ctx, q.Logger(), "disconnect", qemuTracingTags, map[string]string{"sandbox_id": q.id}) defer span.End() q.qmpShutdown() @@ -2200,8 +2186,7 @@ func genericAppendPCIeRootPort(devices []govmmQemu.Device, number uint32, machin } func (q *qemu) getThreadIDs(ctx context.Context) (vcpuThreadIDs, error) { - span, _ := katatrace.Trace(ctx, q.Logger(), "getThreadIDs", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) + span, _ := katatrace.Trace(ctx, q.Logger(), "getThreadIDs", qemuTracingTags, map[string]string{"sandbox_id": q.id}) defer span.End() tid := vcpuThreadIDs{} @@ -2266,8 +2251,7 @@ func (q *qemu) resizeVCPUs(ctx context.Context, reqVCPUs uint32) (currentVCPUs u } func (q *qemu) cleanup(ctx context.Context) error { - span, _ := katatrace.Trace(ctx, q.Logger(), "cleanup", qemuTracingTags) - katatrace.AddTag(span, "sandbox_id", q.id) + span, _ := katatrace.Trace(ctx, q.Logger(), "cleanup", qemuTracingTags, map[string]string{"sandbox_id": q.id}) defer span.End() for _, fd := range q.fds { diff --git a/src/runtime/virtcontainers/sandbox.go b/src/runtime/virtcontainers/sandbox.go index 1fbc277bab..a5d8112e41 100644 --- a/src/runtime/virtcontainers/sandbox.go +++ b/src/runtime/virtcontainers/sandbox.go @@ -396,8 +396,7 @@ func (s *Sandbox) IOStream(containerID, processID string) (io.WriteCloser, io.Re } func createAssets(ctx context.Context, sandboxConfig *SandboxConfig) error { - span, _ := katatrace.Trace(ctx, nil, "createAssets", sandboxTracingTags) - katatrace.AddTag(span, "sandbox_id", sandboxConfig.ID) + span, _ := katatrace.Trace(ctx, nil, "createAssets", sandboxTracingTags, map[string]string{"sandbox_id": sandboxConfig.ID}) defer span.End() for _, name := range types.AssetTypes() { @@ -447,8 +446,7 @@ func (s *Sandbox) getAndStoreGuestDetails(ctx context.Context) error { // to physically create that sandbox i.e. starts a VM for that sandbox to eventually // be started. func createSandbox(ctx context.Context, sandboxConfig SandboxConfig, factory Factory) (*Sandbox, error) { - span, ctx := katatrace.Trace(ctx, nil, "createSandbox", sandboxTracingTags) - katatrace.AddTag(span, "sandbox_id", sandboxConfig.ID) + span, ctx := katatrace.Trace(ctx, nil, "createSandbox", sandboxTracingTags, map[string]string{"sandbox_id": sandboxConfig.ID}) defer span.End() if err := createAssets(ctx, &sandboxConfig); err != nil { @@ -486,8 +484,7 @@ func createSandbox(ctx context.Context, sandboxConfig SandboxConfig, factory Fac } func newSandbox(ctx context.Context, sandboxConfig SandboxConfig, factory Factory) (sb *Sandbox, retErr error) { - span, ctx := katatrace.Trace(ctx, nil, "newSandbox", sandboxTracingTags) - katatrace.AddTag(span, "sandbox_id", sandboxConfig.ID) + span, ctx := katatrace.Trace(ctx, nil, "newSandbox", sandboxTracingTags, map[string]string{"sandbox_id": sandboxConfig.ID}) defer span.End() if !sandboxConfig.valid() { @@ -624,8 +621,7 @@ func (s *Sandbox) createCgroupManager() error { // storeSandbox stores a sandbox config. func (s *Sandbox) storeSandbox(ctx context.Context) error { - span, _ := katatrace.Trace(ctx, s.Logger(), "storeSandbox", sandboxTracingTags) - katatrace.AddTag(span, "sandbox_id", s.id) + span, _ := katatrace.Trace(ctx, s.Logger(), "storeSandbox", sandboxTracingTags, map[string]string{"sandbox_id": s.id}) defer span.End() // flush data to storage @@ -719,8 +715,7 @@ func (s *Sandbox) Delete(ctx context.Context) error { } func (s *Sandbox) startNetworkMonitor(ctx context.Context) error { - span, ctx := katatrace.Trace(ctx, s.Logger(), "startNetworkMonitor", sandboxTracingTags) - katatrace.AddTag(span, "sandbox_id", s.id) + span, ctx := katatrace.Trace(ctx, s.Logger(), "startNetworkMonitor", sandboxTracingTags, map[string]string{"sandbox_id": s.id}) defer span.End() binPath, err := os.Executable() @@ -759,8 +754,7 @@ func (s *Sandbox) createNetwork(ctx context.Context) error { return nil } - span, ctx := katatrace.Trace(ctx, s.Logger(), "createNetwork", sandboxTracingTags) - katatrace.AddTag(span, "sandbox_id", s.id) + span, ctx := katatrace.Trace(ctx, s.Logger(), "createNetwork", sandboxTracingTags, map[string]string{"sandbox_id": s.id}) defer span.End() s.networkNS = NetworkNamespace{ @@ -797,8 +791,7 @@ func (s *Sandbox) postCreatedNetwork(ctx context.Context) error { } func (s *Sandbox) removeNetwork(ctx context.Context) error { - span, ctx := katatrace.Trace(ctx, s.Logger(), "removeNetwork", sandboxTracingTags) - katatrace.AddTag(span, "sandbox_id", s.id) + span, ctx := katatrace.Trace(ctx, s.Logger(), "removeNetwork", sandboxTracingTags, map[string]string{"sandbox_id": s.id}) defer span.End() if s.config.NetworkConfig.NetmonConfig.Enable { @@ -1114,8 +1107,7 @@ func (s *Sandbox) cleanSwap(ctx context.Context) { // startVM starts the VM. func (s *Sandbox) startVM(ctx context.Context) (err error) { - span, ctx := katatrace.Trace(ctx, s.Logger(), "startVM", sandboxTracingTags) - katatrace.AddTag(span, "sandbox_id", s.id) + span, ctx := katatrace.Trace(ctx, s.Logger(), "startVM", sandboxTracingTags, map[string]string{"sandbox_id": s.id}) defer span.End() s.Logger().Info("Starting VM") @@ -1204,8 +1196,7 @@ func (s *Sandbox) startVM(ctx context.Context) (err error) { // stopVM: stop the sandbox's VM func (s *Sandbox) stopVM(ctx context.Context) error { - span, ctx := katatrace.Trace(ctx, s.Logger(), "stopVM", sandboxTracingTags) - katatrace.AddTag(span, "sandbox_id", s.id) + span, ctx := katatrace.Trace(ctx, s.Logger(), "stopVM", sandboxTracingTags, map[string]string{"sandbox_id": s.id}) defer span.End() s.Logger().Info("Stopping sandbox in the VM") @@ -1558,8 +1549,7 @@ func (s *Sandbox) ResumeContainer(ctx context.Context, containerID string) error // createContainers registers all containers, create the // containers in the guest and starts one shim per container. func (s *Sandbox) createContainers(ctx context.Context) error { - span, ctx := katatrace.Trace(ctx, s.Logger(), "createContainers", sandboxTracingTags) - katatrace.AddTag(span, "sandbox_id", s.id) + span, ctx := katatrace.Trace(ctx, s.Logger(), "createContainers", sandboxTracingTags, map[string]string{"sandbox_id": s.id}) defer span.End() for i := range s.config.Containers { @@ -1631,8 +1621,7 @@ func (s *Sandbox) Start(ctx context.Context) error { // will be destroyed. // When force is true, ignore guest related stop failures. func (s *Sandbox) Stop(ctx context.Context, force bool) error { - span, ctx := katatrace.Trace(ctx, s.Logger(), "Stop", sandboxTracingTags) - katatrace.AddTag(span, "sandbox_id", s.id) + span, ctx := katatrace.Trace(ctx, s.Logger(), "Stop", sandboxTracingTags, map[string]string{"sandbox_id": s.id}) defer span.End() if s.state.State == types.StateStopped { @@ -1734,8 +1723,7 @@ func (s *Sandbox) unsetSandboxBlockIndex(index int) error { // HotplugAddDevice is used for add a device to sandbox // Sandbox implement DeviceReceiver interface from device/api/interface.go func (s *Sandbox) HotplugAddDevice(ctx context.Context, device api.Device, devType config.DeviceType) error { - span, ctx := katatrace.Trace(ctx, s.Logger(), "HotplugAddDevice", sandboxTracingTags) - katatrace.AddTag(span, "sandbox_id", s.id) + span, ctx := katatrace.Trace(ctx, s.Logger(), "HotplugAddDevice", sandboxTracingTags, map[string]string{"sandbox_id": s.id}) defer span.End() if s.config.SandboxCgroupOnly {