github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-06-28 16:27:50 +00:00
Code Issues Projects Releases Wiki Activity

improvement: Fix naming conventions for span name and log subsystem

Browse Source 
Normally, the span name should be the same as the function name, and the log subsystem should not contain spaces.

Fixes #6153

Signed-off-by: joannejchen <chenjjoanne@gmail.com>
This commit is contained in:
joannejchen 2023-02-02 15:23:29 -06:00
parent df93439c3b
commit 9794c52c65
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/runtime/virtcontainers/fs_share_linux.go
View File

@ -42,16 +42,16 @@ func NewFilesystemShare(s *Sandbox) (FilesystemSharer, error) {
}, nil }, nil
} }
// Logger returns a logrus logger appropriate for logging Filesystem sharing messages // Logger returns a logrus logger appropriate for logging filesystem sharing messages
func (f *FilesystemShare) Logger() *logrus.Entry { func (f *FilesystemShare) Logger() *logrus.Entry {
return virtLog.WithFields(logrus.Fields{ return virtLog.WithFields(logrus.Fields{
"subsystem": "filesystem share", "subsystem": "fs_share",
"sandbox": f.sandbox.ID(), "sandbox": f.sandbox.ID(),
}) })
} }
func (f *FilesystemShare) prepareBindMounts(ctx context.Context) error { func (f *FilesystemShare) prepareBindMounts(ctx context.Context) error {
span, ctx := katatrace.Trace(ctx, f.Logger(), "setupBindMounts", fsShareTracingTags) span, ctx := katatrace.Trace(ctx, f.Logger(), "prepareBindMounts", fsShareTracingTags)
defer span.End() defer span.End()
var err error var err error