From 9a7c5b914e052e0986142c9f46b631460847e281 Mon Sep 17 00:00:00 2001 From: stevenhorsman Date: Thu, 27 Mar 2025 16:59:54 +0000 Subject: [PATCH 1/2] ci: required-tests fixes/updates - Remove metrics setup job - Update some truncation typos of job names - Add shellcheck-required - Remove the ok-to-test as a required label on the build test as it isn't needed as a trigger Signed-off-by: stevenhorsman --- tools/testing/gatekeeper/required-tests.yaml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/testing/gatekeeper/required-tests.yaml b/tools/testing/gatekeeper/required-tests.yaml index 8e7a7726c..dac3fba25 100644 --- a/tools/testing/gatekeeper/required-tests.yaml +++ b/tools/testing/gatekeeper/required-tests.yaml @@ -3,6 +3,7 @@ required_tests: - Commit Message Check / Commit Message Check - Pull request WIP checks / WIP Check - Darwin tests / test + - Shellcheck required / shellcheck-required # TODO: cargo-deny-runner.yaml not yet treated as conditional - Cargo Crates Check Runner / cargo-deny-runner @@ -100,7 +101,6 @@ mapping: - Kata Containers CI / kata-containers-ci-on-push / run-kata-deploy-tests / run-kata-deploy-tests (qemu, microk8s) - Kata Containers CI / kata-containers-ci-on-push / run-kata-deploy-tests / run-kata-deploy-tests (qemu, rke2) - Kata Containers CI / kata-containers-ci-on-push / run-kata-monitor-tests / run-monitor (qemu, crio) - - Kata Containers CI / kata-containers-ci-on-push / run-metrics-tests / Kata Setup required-labels: - ok-to-test build: @@ -126,7 +126,6 @@ mapping: - Kata Containers CI / kata-containers-ci-on-push / build-kata-static-tarball-amd64 / create-kata-tarball - Kata Containers CI / kata-containers-ci-on-push / publish-kata-deploy-payload-amd64 / kata-payload required-labels: - - ok-to-test static: # Checks that static checks are passing names: @@ -155,8 +154,8 @@ mapping: - Static checks / build-checks / check (make vendor, runtime-rs, src/runtime-rs, rust) - Static checks / build-checks / check (make vendor, runtime, src/runtime, golang, XDG_RUNTIME_DIR) - Static checks / build-checks / check (make vendor, trace-forwarder, src/tools/trace-forwarder, rust) - - Static checks / build-checks / check (sudo -E PATH="$PATH" make test, agent-ctl, src/tools/agent-ctl, rust, protobuf-compiler, c... - - Static checks / build-checks / check (sudo -E PATH="$PATH" make test, agent, src/agent, rust, libdevmapper, libseccomp, protobuf... + - Static checks / build-checks / check (sudo -E PATH="$PATH" make test, agent-ctl, src/tools/agent-ctl, rust, protobuf-compiler, clang) + - Static checks / build-checks / check (sudo -E PATH="$PATH" make test, agent, src/agent, rust, libdevmapper, libseccomp, protobuf-compiler, clang) - Static checks / build-checks / check (sudo -E PATH="$PATH" make test, dragonball, src/dragonball, rust) - Static checks / build-checks / check (sudo -E PATH="$PATH" make test, genpolicy, src/tools/genpolicy, rust, protobuf-compiler) - Static checks / build-checks / check (sudo -E PATH="$PATH" make test, kata-ctl, src/tools/kata-ctl, rust) From 576747b0606a104c57759502f7aa05456cb8f50b Mon Sep 17 00:00:00 2001 From: stevenhorsman Date: Fri, 28 Mar 2025 16:55:59 +0000 Subject: [PATCH 2/2] ci: Skip tests if we only update the required list When making new tests required, or removing existing tests from required, this doesn't impact the CI jobs, so we don't need to run all the tests. Signed-off-by: stevenhorsman --- tools/testing/gatekeeper/required-tests.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/gatekeeper/required-tests.yaml b/tools/testing/gatekeeper/required-tests.yaml index dac3fba25..8a7020b12 100644 --- a/tools/testing/gatekeeper/required-tests.yaml +++ b/tools/testing/gatekeeper/required-tests.yaml @@ -17,6 +17,7 @@ paths: - "^ci/openshift-ci/": [] - "^\\.github/workflows/static-checks": ["static"] - "^\\.github/workflows/": [] + - "^tools/testing/gatekeeper/required-tests.yaml": [] # TODO: Expand filters # Documentation #- "\\.rst$": ["build"]