From 9c0d069ac79790ebaeca96349b6051fc6c104ac7 Mon Sep 17 00:00:00 2001
From: Dan Mihai <dmihai@microsoft.com>
Date: Tue, 18 Mar 2025 23:50:39 +0000
Subject: [PATCH] tests: tests_common: prevent globbing and word splitting
ShellCheck:
note: Double quote to prevent globbing and word splitting. [SC2086]
Signed-off-by: Dan Mihai <dmihai@microsoft.com>
---
tests/integration/kubernetes/tests_common.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/integration/kubernetes/tests_common.sh b/tests/integration/kubernetes/tests_common.sh
index 62fd5e0d82..e72afff771 100644
--- a/tests/integration/kubernetes/tests_common.sh
+++ b/tests/integration/kubernetes/tests_common.sh
@@ -284,7 +284,7 @@ add_allow_all_policy_to_yaml() {
# Previous version of yq was not ready to handle multiple objects in a single yaml.
# By default was changing only the first object.
# With yq>4 we need to make it explicit during the read and write.
- local resource_kind="$(yq .kind ${yaml_file} | head -1)"
+ local resource_kind=$(yq .kind "${yaml_file}" | head -1)
case "${resource_kind}" in
@@ -372,7 +372,7 @@ teardown_common() {
# Print the node journal since the test start time if a bats test is not completed
if [[ -n "${node_start_time}" && -z "${BATS_TEST_COMPLETED}" ]]; then
echo "DEBUG: system logs of node '${node}' since test start time (${node_start_time})"
- exec_host "${node}" journalctl -x -t "kata" --since '"'${node_start_time}'"' || true
+ exec_host "${node}" journalctl -x -t "kata" --since '"'"${node_start_time}"'"' || true
fi
}