github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-07-03 18:47:03 +00:00
Code Issues Projects Releases Wiki Activity

runtime: make kata-runtime check error more understandable

Browse Source 
If device /dev/kvm does not exist, kata-runtime check would fail with
an ambiguous error messae 'no such file or directory'. I added a little
more details to make it understandable and it will belike:

```
ERRO[0000] cannot open kvm device: no such file or directory  arch=arm64 check-type=full device=/dev/kvm name=kata-runtime pid=2849085 source=runtime
ERRO[0000] no such file or directory                          arch=arm64 name=kata-runtime pid=2849085 source=runtime
no such file or directory
```

Signed-off-by: cncal <flycalvin@qq.com>
This commit is contained in:
cncal 2024-05-02 10:18:58 +08:00
parent 3456483df9
commit 9caa7beb1f
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/runtime/cmd/kata-runtime/kata-check.go
View File

@ -471,16 +471,15 @@ func genericArchKernelParamHandler(onVMM bool, fields logrus.Fields, msg string)
// genericKvmIsUsable determines if it will be possible to create a full virtual machine // genericKvmIsUsable determines if it will be possible to create a full virtual machine
// by creating a minimal VM and then deleting it. // by creating a minimal VM and then deleting it.
func genericKvmIsUsable() error { func genericKvmIsUsable() error {
flags := syscall.O_RDWR | syscall.O_CLOEXEC fieldLogger := kataLog.WithField("check-type", "full")
f, err := syscall.Open(kvmDevice, flags, 0) f, err := syscall.Open(kvmDevice, syscall.O_RDWR|syscall.O_CLOEXEC, 0)
if err != nil { if err != nil {
fieldLogger.WithField("device", kvmDevice).Errorf("cannot open kvm device: %v", err)
return err return err
} }
defer syscall.Close(f) defer syscall.Close(f)
fieldLogger := kataLog.WithField("check-type", "full")
fieldLogger.WithField("device", kvmDevice).Info("device available") fieldLogger.WithField("device", kvmDevice).Info("device available")
vm, _, errno := syscall.Syscall(syscall.SYS_IOCTL, vm, _, errno := syscall.Syscall(syscall.SYS_IOCTL,