From a1787da97c2a85bb68efe302b7c39131ddf4afc1 Mon Sep 17 00:00:00 2001 From: Sebastien Boeuf Date: Thu, 16 Aug 2018 14:43:31 -0700 Subject: [PATCH] virtcontainers: qemu: Don't shutdown QMP from hotplug The QMP shutdown is taken care of by the sandbox release, through a call to hypervisor.disconnect(). By shutting down the QMP at the qemu level directly, we are creating some unrecoverable errors by trying to close an already closed channel. This patch simply removes the faulty code, following the same design other hotplug functions are designed. Fixes #627 Signed-off-by: Sebastien Boeuf --- virtcontainers/qemu.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/virtcontainers/qemu.go b/virtcontainers/qemu.go index 7af48a67d2..151222de53 100644 --- a/virtcontainers/qemu.go +++ b/virtcontainers/qemu.go @@ -835,12 +835,6 @@ func (q *qemu) hotplugMacvtap(drive VirtualEndpoint) error { } func (q *qemu) hotplugNetDevice(drive VirtualEndpoint, op operation) error { - defer func(qemu *qemu) { - if q.qmpMonitorCh.qmp != nil { - q.qmpMonitorCh.qmp.Shutdown() - } - }(q) - err := q.qmpSetup() if err != nil { return err