github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-04-29 12:14:48 +00:00
Code Issues Projects Releases Wiki Activity

virtiofsd: Convert legacy -o sub-options to their -- replacement

Browse Source 
The `-o` option is the legacy way to configure virtiofsd, inherited
from the C implementation. The rust implementation honours it for
compatibility but it logs deprecation warnings.

Let's use the replacement options in the go shim code. Also drop
references to `-o` from the configuration TOML file.

Fixes #7111

Signed-off-by: Greg Kurz <groug@kaod.org>
This commit is contained in:
Greg Kurz 2023-06-14 12:33:45 +02:00
parent 8e00dc6944
commit a43ea24dfc
5 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/runtime/Makefile
View File

@ -232,7 +232,7 @@ DEFVIRTIOFSQUEUESIZE ?= 1024
# #
# see `virtiofsd -h` for possible options. # see `virtiofsd -h` for possible options.
# Make sure you quote args. # Make sure you quote args.
DEFVIRTIOFSEXTRAARGS ?= [\"--thread-pool-size=1\", \"-o\", \"announce_submounts\"] DEFVIRTIOFSEXTRAARGS ?= [\"--thread-pool-size=1\", \"--announce-submounts\"]
DEFENABLEIOTHREADS := false DEFENABLEIOTHREADS := false
DEFENABLEVHOSTUSERSTORE := false DEFENABLEVHOSTUSERSTORE := false
DEFVHOSTUSERSTOREPATH := $(PKGRUNDIR)/vhost-user DEFVHOSTUSERSTOREPATH := $(PKGRUNDIR)/vhost-user

4
src/runtime/config/configuration-clh.toml.in
View File

@ -150,9 +150,9 @@ virtio_fs_queue_size = @DEFVIRTIOFSQUEUESIZE@
# Extra args for virtiofsd daemon # Extra args for virtiofsd daemon
# #
# Format example: # Format example:
# ["-o", "arg1=xxx,arg2", "-o", "hello world", "--arg3=yyy"] # ["--arg1=xxx", "--arg2=yyy"]
# Examples: # Examples:
# Set virtiofsd log level to debug : ["-o", "log_level=debug"] or ["-d"] # Set virtiofsd log level to debug : ["--log-level=debug"]
# see `virtiofsd -h` for possible options. # see `virtiofsd -h` for possible options.
virtio_fs_extra_args = @DEFVIRTIOFSEXTRAARGS@ virtio_fs_extra_args = @DEFVIRTIOFSEXTRAARGS@

4
src/runtime/config/configuration-qemu.toml.in
View File

@ -197,9 +197,9 @@ virtio_fs_queue_size = @DEFVIRTIOFSQUEUESIZE@
# Extra args for virtiofsd daemon # Extra args for virtiofsd daemon
# #
# Format example: # Format example:
# ["-o", "arg1=xxx,arg2", "-o", "hello world", "--arg3=yyy"] # ["--arg1=xxx", "--arg2=yyy"]
# Examples: # Examples:
# Set virtiofsd log level to debug : ["-o", "log_level=debug"] or ["-d"] # Set virtiofsd log level to debug : ["--log-level=debug"]
# #
# see `virtiofsd -h` for possible options. # see `virtiofsd -h` for possible options.
virtio_fs_extra_args = @DEFVIRTIOFSEXTRAARGS@ virtio_fs_extra_args = @DEFVIRTIOFSEXTRAARGS@

4
src/runtime/virtcontainers/virtiofsd.go
View File

@ -186,9 +186,9 @@ func (v *virtiofsd) args(FdSocketNumber uint) ([]string, error) {
// Send logs to syslog // Send logs to syslog
"--syslog", "--syslog",
// cache mode for virtiofsd // cache mode for virtiofsd
"-o", "cache=" + v.cache, "--cache=" + v.cache,
// shared directory tree // shared directory tree
"-o", "source=" + v.sourcePath, "--shared-dir=" + v.sourcePath,
// fd number of vhost-user socket // fd number of vhost-user socket
fmt.Sprintf("--fd=%v", FdSocketNumber), fmt.Sprintf("--fd=%v", FdSocketNumber),
} }

4
src/runtime/virtcontainers/virtiofsd_test.go
View File

@ -79,12 +79,12 @@ func TestVirtiofsdArgs(t *testing.T) {
cache: "none", cache: "none",
} }
expected := "--syslog -o cache=none -o source=/run/kata-shared/foo --fd=123" expected := "--syslog --cache=none --shared-dir=/run/kata-shared/foo --fd=123"
args, err := v.args(123) args, err := v.args(123)
assert.NoError(err) assert.NoError(err)
assert.Equal(expected, strings.Join(args, " ")) assert.Equal(expected, strings.Join(args, " "))
expected = "--syslog -o cache=none -o source=/run/kata-shared/foo --fd=456" expected = "--syslog --cache=none --shared-dir=/run/kata-shared/foo --fd=456"
args, err = v.args(456) args, err = v.args(456)
assert.NoError(err) assert.NoError(err)
assert.Equal(expected, strings.Join(args, " ")) assert.Equal(expected, strings.Join(args, " "))