github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-04-28 11:44:38 +00:00
Code Issues Projects Releases Wiki Activity

runtime: remove SharedVersions field dead code

Browse Source 
SharedVersion fiel add a versiontable property that isn't supported by upstream QEMU.
This is dead code since virtcontainers isn't setting SharedVersions to true.

Fixes: #7720

Signed-off-by: Kvlil <kalil.pelissier@gmail.com>
This commit is contained in:
Kvlil 2024-01-12 10:20:06 +00:00
parent bb1ada1a8b
commit a4b208a712
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/runtime/pkg/govmm/qemu/qemu.go
View File

@ -1352,15 +1352,14 @@ func (dev LoaderDevice) QemuParams(config *Config) []string {
// in to the guest // in to the guest
// nolint: govet // nolint: govet
type VhostUserDevice struct { type VhostUserDevice struct {
SocketPath string //path to vhostuser socket on host SocketPath string //path to vhostuser socket on host
CharDevID string CharDevID string
TypeDevID string //variable QEMU parameter based on value of VhostUserType TypeDevID string //variable QEMU parameter based on value of VhostUserType
Address string //used for MAC address in net case Address string //used for MAC address in net case
Tag string //virtio-fs volume id for mounting inside guest Tag string //virtio-fs volume id for mounting inside guest
CacheSize uint32 //virtio-fs DAX cache size in MiB CacheSize uint32 //virtio-fs DAX cache size in MiB
QueueSize uint32 //size of virtqueues QueueSize uint32 //size of virtqueues
SharedVersions bool //enable virtio-fs shared version metadata VhostUserType DeviceDriver
VhostUserType DeviceDriver
// ROMFile specifies the ROM file being used for this device. // ROMFile specifies the ROM file being used for this device.
ROMFile string ROMFile string
@ -1534,9 +1533,6 @@ func (vhostuserDev VhostUserDevice) QemuFSParams(config *Config) []string {
if vhostuserDev.CacheSize != 0 { if vhostuserDev.CacheSize != 0 {
deviceParams = append(deviceParams, fmt.Sprintf("cache-size=%dM", vhostuserDev.CacheSize)) deviceParams = append(deviceParams, fmt.Sprintf("cache-size=%dM", vhostuserDev.CacheSize))
} }
if vhostuserDev.SharedVersions {
deviceParams = append(deviceParams, "versiontable=/dev/shm/fuse_shared_versions")
}
if vhostuserDev.Transport.isVirtioCCW(config) { if vhostuserDev.Transport.isVirtioCCW(config) {
if config.Knobs.IOMMUPlatform { if config.Knobs.IOMMUPlatform {
deviceParams = append(deviceParams, "iommu_platform=on") deviceParams = append(deviceParams, "iommu_platform=on")