From a4ed797756f100631c1b60cfde393d8ddd095dc7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Tue, 21 Apr 2026 18:03:29 +0200 Subject: [PATCH] tools: Fix shellcheck issues in build-static-stratovirt.sh MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix shellcheck warnings and notes identified by running shellcheck --severity=style. Signed-off-by: Fabiano Fidêncio --- .../stratovirt/build-static-stratovirt.sh | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/packaging/static-build/stratovirt/build-static-stratovirt.sh b/tools/packaging/static-build/stratovirt/build-static-stratovirt.sh index 30288eb7db..44d23d8d7a 100755 --- a/tools/packaging/static-build/stratovirt/build-static-stratovirt.sh +++ b/tools/packaging/static-build/stratovirt/build-static-stratovirt.sh @@ -11,28 +11,28 @@ set -o pipefail ARCH=$(uname -m) # Currently, StratoVirt only support x86_64 and aarch64. -[ "${ARCH}" != "x86_64" ] && [ "${ARCH}" != "aarch64" ] && exit +[[ "${ARCH}" != "x86_64" ]] && [[ "${ARCH}" != "aarch64" ]] && exit script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" +# shellcheck source=/dev/null source "${script_dir}/../../scripts/lib.sh" info "Get stratovirt information from runtime versions.yaml" stratovirt_url="${stratovirt_url:-}" -[ -n "$stratovirt_url" ] || stratovirt_url=$(get_from_kata_deps ".assets.hypervisor.stratovirt.url") -[ -n "$stratovirt_url" ] || die "failed to get stratovirt url" +[[ -n "${stratovirt_url}" ]] || stratovirt_url=$(get_from_kata_deps ".assets.hypervisor.stratovirt.url") +[[ -n "${stratovirt_url}" ]] || die "failed to get stratovirt url" stratovirt_version="${stratovirt_version:-}" -[ -n "$stratovirt_version" ] || stratovirt_version=$(get_from_kata_deps ".assets.hypervisor.stratovirt.version") -[ -n "$stratovirt_version" ] || die "failed to get stratovirt version" +[[ -n "${stratovirt_version}" ]] || stratovirt_version=$(get_from_kata_deps ".assets.hypervisor.stratovirt.version") +[[ -n "${stratovirt_version}" ]] || die "failed to get stratovirt version" pull_stratovirt_released_binary() { file_name="stratovirt-static-${stratovirt_version##*v}-${ARCH}" download_url="${stratovirt_url}/releases/download/${stratovirt_version}/${file_name}.tar.gz" - curl -L ${download_url} -o ${file_name}.tar.gz + curl -L "${download_url}" -o "${file_name}.tar.gz" mkdir -p static-stratovirt - tar zxvf ${file_name}.tar.gz -C static-stratovirt + tar zxvf "${file_name}.tar.gz" -C static-stratovirt } pull_stratovirt_released_binary -