From a8fad6893a938c00194f2e6875ce6142d41bb4c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Mon, 28 Oct 2024 11:06:35 +0100 Subject: [PATCH] workflows: Possibly fix the release workflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The only reason we had this one passing for amd64 is because the check was done using the wrong variable (`matrix.stage`, while in the other workflows the variable used is `inputs.stage`). The commit that broke the release process is 67a8665f51d78e1138c, which blindly copy & pasted the logic from the matrix assets. Signed-off-by: Fabiano Fidêncio --- .github/workflows/build-kata-static-tarball-amd64.yaml | 1 - .github/workflows/build-kata-static-tarball-arm64.yaml | 1 - .github/workflows/build-kata-static-tarball-ppc64le.yaml | 1 - .github/workflows/build-kata-static-tarball-s390x.yaml | 1 - 4 files changed, 4 deletions(-) diff --git a/.github/workflows/build-kata-static-tarball-amd64.yaml b/.github/workflows/build-kata-static-tarball-amd64.yaml index fdc71aec0d..27a00c11da 100644 --- a/.github/workflows/build-kata-static-tarball-amd64.yaml +++ b/.github/workflows/build-kata-static-tarball-amd64.yaml @@ -183,7 +183,6 @@ jobs: RELEASE: ${{ inputs.stage == 'release' && 'yes' || 'no' }} - name: store-artifact shim-v2 - if: ${{ matrix.stage != 'release' }} uses: actions/upload-artifact@v4 with: name: kata-artifacts-amd64-shim-v2${{ inputs.tarball-suffix }} diff --git a/.github/workflows/build-kata-static-tarball-arm64.yaml b/.github/workflows/build-kata-static-tarball-arm64.yaml index a5e8ee9a0d..a4df332892 100644 --- a/.github/workflows/build-kata-static-tarball-arm64.yaml +++ b/.github/workflows/build-kata-static-tarball-arm64.yaml @@ -123,7 +123,6 @@ jobs: RELEASE: ${{ inputs.stage == 'release' && 'yes' || 'no' }} - name: store-artifact shim-v2 - if: ${{ inputs.stage != 'release' }} uses: actions/upload-artifact@v4 with: name: kata-artifacts-arm64-shim-v2${{ inputs.tarball-suffix }} diff --git a/.github/workflows/build-kata-static-tarball-ppc64le.yaml b/.github/workflows/build-kata-static-tarball-ppc64le.yaml index 9f4891d41d..79e7ad5b78 100644 --- a/.github/workflows/build-kata-static-tarball-ppc64le.yaml +++ b/.github/workflows/build-kata-static-tarball-ppc64le.yaml @@ -129,7 +129,6 @@ jobs: RELEASE: ${{ inputs.stage == 'release' && 'yes' || 'no' }} - name: store-artifact shim-v2 - if: ${{ inputs.stage != 'release' }} uses: actions/upload-artifact@v4 with: name: kata-artifacts-ppc64le-shim-v2${{ inputs.tarball-suffix }} diff --git a/.github/workflows/build-kata-static-tarball-s390x.yaml b/.github/workflows/build-kata-static-tarball-s390x.yaml index 97eed6e0d7..693f81a478 100644 --- a/.github/workflows/build-kata-static-tarball-s390x.yaml +++ b/.github/workflows/build-kata-static-tarball-s390x.yaml @@ -203,7 +203,6 @@ jobs: RELEASE: ${{ inputs.stage == 'release' && 'yes' || 'no' }} - name: store-artifact shim-v2 - if: ${{ inputs.stage != 'release' }} uses: actions/upload-artifact@v4 with: name: kata-artifacts-s390x-shim-v2${{ inputs.tarball-suffix }}