From b23d0949285d7f29e8c737fb50c9ff9d71088c8d Mon Sep 17 00:00:00 2001 From: "alex.lyn" Date: Thu, 24 Jul 2025 14:55:07 +0800 Subject: [PATCH] CI: Introduce CI for libs to Improve code quality and reduce noises Currently, runtime-rs related code within the libs directory lacks sufficient CI protection. We frequently observe the following issues: - Inconsistent Code Formatting: Code that has not been properly formatted is merged. - Failing Tests: Code with failing unit or integration tests is merged. To address these issues, we need introduce stricter CI checks for the libs directory. This may specifically include: - Code Formatting Checks - Mandatory Test Runs Fixes #11512 Signed-off-by: alex.lyn --- .github/workflows/build-checks.yaml | 4 ++++ tools/testing/gatekeeper/required-tests.yaml | 3 +++ 2 files changed, 7 insertions(+) diff --git a/.github/workflows/build-checks.yaml b/.github/workflows/build-checks.yaml index 903bc7e914..123d935ab1 100644 --- a/.github/workflows/build-checks.yaml +++ b/.github/workflows/build-checks.yaml @@ -42,6 +42,10 @@ jobs: path: src/runtime-rs needs: - rust + - name: libs + path: src/libs + needs: + - rust - name: agent-ctl path: src/tools/agent-ctl needs: diff --git a/tools/testing/gatekeeper/required-tests.yaml b/tools/testing/gatekeeper/required-tests.yaml index 3c57bddb96..2eacc39cfc 100644 --- a/tools/testing/gatekeeper/required-tests.yaml +++ b/tools/testing/gatekeeper/required-tests.yaml @@ -136,6 +136,7 @@ mapping: - Static checks / build-checks / check (make check, dragonball, src/dragonball, rust) - Static checks / build-checks / check (make check, genpolicy, src/tools/genpolicy, rust, protobuf-compiler) - Static checks / build-checks / check (make check, kata-ctl, src/tools/kata-ctl, rust) + - Static checks / build-checks / check (make check, libs, src/libs, rust) - Static checks / build-checks / check (make check, runtime-rs, src/runtime-rs, rust) - Static checks / build-checks / check (make check, runtime, src/runtime, golang, XDG_RUNTIME_DIR) - Static checks / build-checks / check (make check, trace-forwarder, src/tools/trace-forwarder, rust) @@ -144,6 +145,7 @@ mapping: - Static checks / build-checks / check (make test, dragonball, src/dragonball, rust) - Static checks / build-checks / check (make test, genpolicy, src/tools/genpolicy, rust, protobuf-compiler) - Static checks / build-checks / check (make test, kata-ctl, src/tools/kata-ctl, rust) + - Static checks / build-checks / check (make test, libs, src/libs, rust) - Static checks / build-checks / check (make test, runtime-rs, src/runtime-rs, rust) - Static checks / build-checks / check (make test, runtime, src/runtime, golang, XDG_RUNTIME_DIR) - Static checks / build-checks / check (make test, trace-forwarder, src/tools/trace-forwarder, rust) @@ -160,6 +162,7 @@ mapping: - Static checks / build-checks / check (sudo -E PATH="$PATH" make test, dragonball, src/dragonball, rust) - Static checks / build-checks / check (sudo -E PATH="$PATH" make test, genpolicy, src/tools/genpolicy, rust, protobuf-compiler) - Static checks / build-checks / check (sudo -E PATH="$PATH" make test, kata-ctl, src/tools/kata-ctl, rust) + - Static checks / build-checks / check (sudo -E PATH="$PATH" make test, libs, src/libs, rust) - Static checks / build-checks / check (sudo -E PATH="$PATH" make test, runtime-rs, src/runtime-rs, rust) - Static checks / build-checks / check (sudo -E PATH="$PATH" make test, runtime, src/runtime, golang, XDG_RUNTIME_DIR) - Static checks / build-checks / check (sudo -E PATH="$PATH" make test, trace-forwarder, src/tools/trace-forwarder, rust)