github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-06-24 14:32:33 +00:00
Code Issues Projects Releases Wiki Activity

runtime-rs: Fix the issues with stderr fifo

Browse Source 
When tty is enabled, stderr fifo should never be opened.

Fixes: #10637

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
This commit is contained in:
Xuewei Niu 2024-12-10 17:12:36 +08:00
parent 037281d699
commit b4695f6303
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/runtime-rs/crates/runtimes/virt_container/src/container_manager/process.rs
View File

@ -128,11 +128,13 @@ impl Process {
pub fn pre_fifos_open(&mut self) -> Result<()> { pub fn pre_fifos_open(&mut self) -> Result<()> {
if let Some(ref stdout) = self.stdout { if let Some(ref stdout) = self.stdout {
self.stdout_r = Some(open_fifo_read(stdout)?); self.stdout_r = Some(open_fifo_read(stdout).context("open stdout")?);
} }
if let Some(ref stderr) = self.stderr { if !self.terminal {
self.stderr_r = Some(open_fifo_read(stderr)?); if let Some(ref stderr) = self.stderr {
self.stderr_r = Some(open_fifo_read(stderr).context("open stderr")?);
}
} }
Ok(()) Ok(())