From b8b6733f629a2d1cbc9e3bc771eefcf37e1e7f67 Mon Sep 17 00:00:00 2001
From: Ted Yu <yute@vmware.com>
Date: Thu, 21 Nov 2019 12:41:50 -0800
Subject: [PATCH] vc: Persist file handle may leak in FS#ToDisk

Fixes #2241

Signed-off-by: Ted Yu <yuzhihong@gmail.com>
---
 virtcontainers/persist/fs/fs.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virtcontainers/persist/fs/fs.go b/virtcontainers/persist/fs/fs.go
index 8aca6fb9a1..ec3c59823b 100644
--- a/virtcontainers/persist/fs/fs.go
+++ b/virtcontainers/persist/fs/fs.go
@@ -139,10 +139,10 @@ func (fs *FS) ToDisk(ss persistapi.SandboxState, cs map[string]persistapi.Contai
 			return err
 		}
 
+		defer cf.Close()
 		if err := json.NewEncoder(cf).Encode(cstate); err != nil {
 			return err
 		}
-		cf.Close()
 	}
 
 	return nil