From b8f1a688340c7b1cfe5a1cb1bbe6a792dc97acf8 Mon Sep 17 00:00:00 2001 From: "James O. D. Hunt" Date: Thu, 19 Apr 2018 16:24:38 +0100 Subject: [PATCH] rootfs: Simplify code Use a variable in `copy_kernel_modules()` to avoid the duplicated string. Signed-off-by: James O. D. Hunt --- rootfs-builder/rootfs.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/rootfs-builder/rootfs.sh b/rootfs-builder/rootfs.sh index d838009b71..517859d649 100755 --- a/rootfs-builder/rootfs.sh +++ b/rootfs-builder/rootfs.sh @@ -136,9 +136,11 @@ copy_kernel_modules() [ -z "$module_dir" ] && die "need module directory" [ -z "$rootfs_dir" ] && die "need rootfs directory" + local destdir="${rootfs_dir}/lib/modules" + info "Copy kernel modules from ${KERNEL_MODULES_DIR}" - mkdir -p ${rootfs_dir}/lib/modules/ - cp -a ${KERNEL_MODULES_DIR} ${rootfs_dir}/lib/modules/ + mkdir -p "${destdir}" + cp -a "${KERNEL_MODULES_DIR}" "${dest_dir}/" OK "Kernel modules copied" }