From c0f0fc9f9bd386a3e20167ae75766ae29eb4d415 Mon Sep 17 00:00:00 2001 From: Julio Montes Date: Fri, 26 Apr 2019 07:34:48 -0500 Subject: [PATCH] scripts: improve configure-hypervisor.sh Change weird condition to check qemu >=3.1 Add comment explaining the malloc-trim option. fixes #462 Signed-off-by: Julio Montes --- scripts/configure-hypervisor.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/configure-hypervisor.sh b/scripts/configure-hypervisor.sh index 0be7fdc696..d419c0e43b 100755 --- a/scripts/configure-hypervisor.sh +++ b/scripts/configure-hypervisor.sh @@ -304,7 +304,7 @@ generate_qemu_options() { # implicitly enabled in Fedora 27). qemu_options+=(size:--disable-linux-aio) - if [[ "${qemu_version_major}" -ge 4 || ( "${qemu_version_major}" -ge 3 && "${qemu_version_minor}" -ge 1 ) ]]; then + if [[ "${qemu_version_major}" -ge 4 || ( "${qemu_version_major}" -eq 3 && "${qemu_version_minor}" -ge 1 ) ]]; then # Disable libpmem, vNVDIMM backend (aka rootfs image) shouldn't be modifed # by the guest qemu_options+=(security:--disable-libpmem) @@ -361,9 +361,10 @@ generate_qemu_options() { qemu_options+=(functionality:--enable-attr) qemu_options+=(functionality:--enable-cap-ng) - # AVX2 is enabled by default, make sure it's on - if [[ "${qemu_version_major}" -ge 4 || ( "${qemu_version_major}" -ge 3 && "${qemu_version_minor}" -ge 1 ) ]]; then + if [[ "${qemu_version_major}" -ge 4 || ( "${qemu_version_major}" -eq 3 && "${qemu_version_minor}" -ge 1 ) ]]; then + # AVX2 is enabled by default, make sure it's on. qemu_options+=(speed:--enable-avx2) + # Enable libc malloc_trim() for memory optimization. qemu_options+=(speed:--enable-malloc-trim) fi