From c61f4a859236e2bcab2d646e0420fbf19925e6cc Mon Sep 17 00:00:00 2001 From: Beraldo Leal Date: Tue, 31 Oct 2023 16:17:22 +0000 Subject: [PATCH] protocols: remove unused fieldpath option The +fieldpath option, specific to gogoprotobuf, enabled dynamic field access in protobuf messages, allowing nested fields to be accessed via string paths. This change is part of a larger effort to transition to the official Go protobuf library for better maintainability and community support. Upon review, no instances of dynamic field access were found in the codebase, confirming that the feature is not in use. By removing this unused feature, we simplify the build process and make it easier to complete the transition away from gogoprotobuf. Signed-off-by: Beraldo Leal --- src/libs/protocols/hack/update-generated-proto.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/protocols/hack/update-generated-proto.sh b/src/libs/protocols/hack/update-generated-proto.sh index dbb6d9d470..a383e73bb4 100755 --- a/src/libs/protocols/hack/update-generated-proto.sh +++ b/src/libs/protocols/hack/update-generated-proto.sh @@ -55,7 +55,7 @@ generate_go_sources() { local root_path=$(realpath ../)/libs/protocols/protos local cmd="protoc -I$GOPATH/src:${root_path} \ ---gogottrpc_out=plugins=ttrpc+fieldpath,paths=source_relative,\ +--gogottrpc_out=plugins=ttrpc,paths=source_relative,\ Mgoogle/protobuf/empty.proto=github.com/gogo/protobuf/types\ :$(realpath ../)/runtime/virtcontainers/pkg/agent/protocols/$dir_path \ ${root_path}/$file_name"