From 4011071526a240920cd0b5809fdb973b8d6876a9 Mon Sep 17 00:00:00 2001 From: stevenhorsman Date: Fri, 29 Nov 2024 10:50:02 +0000 Subject: [PATCH 1/2] metrics: Increase minval range for failing tests We've seen a couple of instances recently where the metrics tests are failing due to the results being below the minimum value by ~2%. For tests like latency I'm not sure why values being too low would be an issue, but I've updated the minpercent range of the failing tests to try and get them passing. Signed-off-by: stevenhorsman --- .../ci_worker/checkmetrics-json-clh-kata-metric8.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/metrics/cmd/checkmetrics/ci_worker/checkmetrics-json-clh-kata-metric8.toml b/tests/metrics/cmd/checkmetrics/ci_worker/checkmetrics-json-clh-kata-metric8.toml index 95ddea2575..deca760eb3 100644 --- a/tests/metrics/cmd/checkmetrics/ci_worker/checkmetrics-json-clh-kata-metric8.toml +++ b/tests/metrics/cmd/checkmetrics/ci_worker/checkmetrics-json-clh-kata-metric8.toml @@ -160,7 +160,7 @@ description = "measure container latency" checkvar = ".\"latency\".Results | .[] | .latency.Result" checktype = "mean" midval = 0.75 -minpercent = 20.0 +minpercent = 25.0 maxpercent = 20.0 [[metric]] @@ -212,5 +212,5 @@ description = "iperf" checkvar = ".\"network-iperf3\".Results | .[] | .jitter.Result" checktype = "mean" midval = 0.044 -minpercent = 50.0 +minpercent = 60.0 maxpercent = 50.0 From b87b4b6756cedd8b81e02bc4f4e07b961e963059 Mon Sep 17 00:00:00 2001 From: stevenhorsman Date: Fri, 29 Nov 2024 10:52:16 +0000 Subject: [PATCH 2/2] metrics: Increase ranges range for qemu failing tests We've also seen the qemu metrics tests are failing due to the results being slightly outside the max range for network-iperf3 parallel and minimum for network-iperf3 jitter tests on PRs that have no code changes, so we've increase the bounds to not see false negatives. Signed-off-by: stevenhorsman --- .../ci_worker/checkmetrics-json-qemu-kata-metric8.toml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/metrics/cmd/checkmetrics/ci_worker/checkmetrics-json-qemu-kata-metric8.toml b/tests/metrics/cmd/checkmetrics/ci_worker/checkmetrics-json-qemu-kata-metric8.toml index 76b75ddc00..e4c2a31d70 100644 --- a/tests/metrics/cmd/checkmetrics/ci_worker/checkmetrics-json-qemu-kata-metric8.toml +++ b/tests/metrics/cmd/checkmetrics/ci_worker/checkmetrics-json-qemu-kata-metric8.toml @@ -199,8 +199,8 @@ description = "measure container parallel bandwidth using iperf3" checkvar = ".\"network-iperf3\".Results | .[] | .parallel.Result" checktype = "mean" midval = 52644229340.0 -minpercent = 20.0 -maxpercent = 20.0 +minpercent = 25.0 +maxpercent = 25.0 [[metric]] name = "network-iperf3" @@ -211,6 +211,6 @@ description = "iperf" # within (inclusive) checkvar = ".\"network-iperf3\".Results | .[] | .jitter.Result" checktype = "mean" -midval = 0.041 -minpercent = 50.0 -maxpercent = 50.0 +midval = 0.040 +minpercent = 60.0 +maxpercent = 60.0