github/kata-containers
1
0
Fork 2
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-09-12 20:39:30 +00:00
Code Issues Projects Releases Wiki Activity

govmm: Drop QEMU's Daemonize knob

Browse Source 
Code isn't used anymore.

Signed-off-by: Greg Kurz <groug@kaod.org>
This commit is contained in:
Greg Kurz
2024-05-30 19:16:00 +02:00
parent 33eaf69d5f
commit cb5b548ad7
2 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/runtime/pkg/govmm/qemu/qemu.go
View File

@@ -2684,9 +2684,6 @@ type Knobs struct {
// NoGraphic completely disables graphic output. // NoGraphic completely disables graphic output.
NoGraphic bool NoGraphic bool
// Daemonize will turn the qemu process into a daemon
Daemonize bool
// Both HugePages and MemPrealloc require the Memory.Size of the VM // Both HugePages and MemPrealloc require the Memory.Size of the VM
// to be set, as they need to reserve the memory upfront in order // to be set, as they need to reserve the memory upfront in order
// for the VM to boot without errors. // for the VM to boot without errors.
@@ -3125,10 +3122,6 @@ func (config *Config) appendKnobs() {
config.qemuParams = append(config.qemuParams, "--no-shutdown") config.qemuParams = append(config.qemuParams, "--no-shutdown")
} }
if config.Knobs.Daemonize {
config.qemuParams = append(config.qemuParams, "-daemonize")
}
config.appendMemoryKnobs() config.appendMemoryKnobs()
if config.Knobs.Mlock { if config.Knobs.Mlock {

3
src/runtime/pkg/govmm/qemu/qemu_test.go
View File

@@ -445,13 +445,12 @@ func TestAppendEmptyDevice(t *testing.T) {
} }
func TestAppendKnobsAllTrue(t *testing.T) { func TestAppendKnobsAllTrue(t *testing.T) {
var knobsString = "-no-user-config -nodefaults -nographic --no-reboot -daemonize -overcommit mem-lock=on -S" var knobsString = "-no-user-config -nodefaults -nographic --no-reboot -overcommit mem-lock=on -S"
knobs := Knobs{ knobs := Knobs{
NoUserConfig: true, NoUserConfig: true,
NoDefaults: true, NoDefaults: true,
NoGraphic: true, NoGraphic: true,
NoReboot: true, NoReboot: true,
Daemonize: true,
MemPrealloc: true, MemPrealloc: true,
FileBackedMem: true, FileBackedMem: true,
MemShared: true, MemShared: true,