From ccffa29a8eca2b21ac02387e45d45e7405f1ce34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Tue, 21 Apr 2026 18:38:03 +0200 Subject: [PATCH] tools: Fix shellcheck issues in build-static-coco-guest-components.sh MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix shellcheck warnings and notes identified by running shellcheck --severity=style. Signed-off-by: Fabiano Fidêncio --- .../build-static-coco-guest-components.sh | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tools/packaging/static-build/coco-guest-components/build-static-coco-guest-components.sh b/tools/packaging/static-build/coco-guest-components/build-static-coco-guest-components.sh index 2c6467fcaa..604e9ac5c9 100755 --- a/tools/packaging/static-build/coco-guest-components/build-static-coco-guest-components.sh +++ b/tools/packaging/static-build/coco-guest-components/build-static-coco-guest-components.sh @@ -10,16 +10,20 @@ set -o pipefail script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" +# shellcheck source=/dev/null source "${script_dir}/../../scripts/lib.sh" -[ -n "$coco_guest_components_repo" ] || die "failed to get coco-guest-components repo" -[ -n "$coco_guest_components_version" ] || die "failed to get coco-guest-components version" +# shellcheck disable=SC2154 +[[ -n "${coco_guest_components_repo}" ]] || die "failed to get coco-guest-components repo" +# shellcheck disable=SC2154 +[[ -n "${coco_guest_components_version}" ]] || die "failed to get coco-guest-components version" -[ -d "guest-components" ] && rm -rf guest-components +[[ -d "guest-components" ]] && rm -rf guest-components build_coco_guest_components_from_source() { echo "build coco-guest-components from source" + # shellcheck source=/dev/null . /etc/profile.d/rust.sh git clone --depth 1 "${coco_guest_components_repo}" guest-components @@ -28,7 +32,9 @@ build_coco_guest_components_from_source() { git fetch --depth=1 origin "${coco_guest_components_version}" git checkout FETCH_HEAD + # shellcheck disable=SC2154 DESTDIR="${DESTDIR}/usr/local/bin" TEE_PLATFORM=${TEE_PLATFORM} make build + # shellcheck disable=SC2154 strip "target/${RUST_ARCH}-unknown-linux-${LIBC}/release/confidential-data-hub" strip "target/${RUST_ARCH}-unknown-linux-${LIBC}/release/attestation-agent" strip "target/${RUST_ARCH}-unknown-linux-${LIBC}/release/api-server-rest" @@ -36,7 +42,7 @@ build_coco_guest_components_from_source() { install -D -m0644 "confidential-data-hub/hub/src/image/ocicrypt_config.json" "${DESTDIR}/etc/ocicrypt_config.json" - if [ -n "${NV_ATTESTER:-}" ]; then + if [[ -n "${NV_ATTESTER:-}" ]]; then echo "build attestation-agent-nv with nvidia-attester support" rm "target/${RUST_ARCH}-unknown-linux-${LIBC}/release/attestation-agent"