From d21eaaf9e8cc9f6da3ca8f2f4feea2530f83273f Mon Sep 17 00:00:00 2001
From: "James O. D. Hunt" <james.o.hunt@intel.com>
Date: Mon, 22 Oct 2018 09:46:14 +0100
Subject: [PATCH] CI: Rename+cleanup install doc test function

Rename the `check_install_guides()` function to `check_install_docs()`
and clean up:

- Improve messages.
- Add more braces around variables.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
---
 .ci/test-install-docs.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/.ci/test-install-docs.sh b/.ci/test-install-docs.sh
index 45f694e278..3cd5b2fd94 100755
--- a/.ci/test-install-docs.sh
+++ b/.ci/test-install-docs.sh
@@ -15,7 +15,7 @@ info()
 # Detect if any installation documents changed. If so, run the
 # kata manager to "execute" the install guide to ensure the
 # commands it specified result in a working system.
-check_install_guides()
+check_install_docs()
 {
 	if [ -n "$TRAVIS" ]
 	then
@@ -54,13 +54,13 @@ check_install_guides()
 	# No files were changed
 	[ -z "$files" ] && return
 
-	changed=$(echo "$files" | grep "^install/.*\.md$" || true)
+	changed=$(echo "${files}" | grep "^install/.*\.md$" || true)
 
-	[ -z "$changed" ] && info "No install guides modified" && return
+	[ -z "$changed" ] && info "No install documents modified" && return
 
-	info "Found modified install guides: $changed"
+	info "Found modified install documents: ${changed}"
 
-	# Regardless of which distro install guide(s) were changed, we test
+	# Regardless of which installation documents were changed, we test
 	# them all where possible.
 
 	local -r GOPATH=$(go env GOPATH)
@@ -85,4 +85,4 @@ check_install_guides()
 	sudo -E docker run --rm -i --runtime "kata-runtime" busybox echo "$msg"
 }
 
-check_install_guides
+check_install_docs