From d23284a0dc4edb1c098b9cdc75c49d15df285e22 Mon Sep 17 00:00:00 2001 From: Ruoqing He Date: Tue, 18 Feb 2025 18:41:26 +0800 Subject: [PATCH] header_check: Check header for changed text files We are running `header_check` for non-text files like binary files, symbolic link files, image files (pictures) and etc., which does not make sense. Filter out non-text files and run `header_check` only for text files changed. Signed-off-by: Ruoqing He --- tests/static-checks.sh | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tests/static-checks.sh b/tests/static-checks.sh index b61bf6b0a..48cfa69ff 100755 --- a/tests/static-checks.sh +++ b/tests/static-checks.sh @@ -413,10 +413,21 @@ static_check_license_headers() files=$(get_pr_changed_file_details || true) - # Strip off status - files=$(echo "$files"|awk '{print $NF}') + # Strip off status and convert to array + files=($(echo "$files"|awk '{print $NF}')) - # no files were changed + text_files=() + # Filter out non-text files + for file in "${files[@]}"; do + if [[ -f "$file" ]] && file --mime-type "$file" | grep -q "text/"; then + text_files+=("$file") + else + info "Ignoring non-text file: $file" + fi + done + files="${text_files[*]}" + + # no text files were changed [ -z "$files" ] && info "No files found" && popd && return local header_check