github/kata-containers
1
0
Fork 2
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-09-17 06:48:51 +00:00
Code Issues Projects Releases Wiki Activity

kata-deploy: Fix condition always true

Browse Source 
if config.toml does not exist,
`[ -x $(command -v containerd) ]` will always True
(Because it is not enclosed in "").

```
// current code
$ [ -x $(command -v containerd_notfound) ]
$ echo $?
0

// maybe expected code
$ [ -x "$(command -v containerd_notfound)" ]
$ echo $?
1
```

Fixes: #11092

Signed-off-by: Shunsuke Kimura <pbrehpuum@gmail.com>
This commit is contained in:
Shunsuke Kimura
2025-03-28 12:53:55 +09:00
parent 305a5f5e41
commit d3edc90d80
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/packaging/kata-deploy/scripts/kata-deploy.sh
View File

@@ -876,7 +876,7 @@ function main() {
mkdir -p $(dirname "$containerd_conf_file") mkdir -p $(dirname "$containerd_conf_file")
touch "$containerd_conf_file" touch "$containerd_conf_file"
elif [[ "$runtime" == "containerd" ]]; then elif [[ "$runtime" == "containerd" ]]; then
if [ ! -f "$containerd_conf_file" ] && [ -d $(dirname "$containerd_conf_file") ] && [ -x $(command -v containerd) ]; then if [ ! -f "$containerd_conf_file" ] && [ -d $(dirname "$containerd_conf_file") ] && [ -x "$(command -v containerd)" ]; then
containerd config default > "$containerd_conf_file" containerd config default > "$containerd_conf_file"
fi fi
fi fi