From d4bd314d52c50c2f52ca90aeb77c0fb9a89661ee Mon Sep 17 00:00:00 2001 From: stevenhorsman <steven@uk.ibm.com> Date: Thu, 5 Dec 2024 17:46:34 +0000 Subject: [PATCH] workflows: linting: Fix incorrect properties These properties are currently invalid, so either fix, or remove them Signed-off-by: stevenhorsman <steven@uk.ibm.com> --- .github/workflows/cargo-deny-runner.yaml | 2 +- .github/workflows/ci-weekly.yaml | 1 + .github/workflows/docs-url-alive-check.yaml | 2 +- .github/workflows/run-k8s-tests-on-amd64.yaml | 6 +++--- .github/workflows/run-kata-coco-stability-tests.yaml | 4 +++- .github/workflows/run-kata-coco-tests.yaml | 1 - 6 files changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/cargo-deny-runner.yaml b/.github/workflows/cargo-deny-runner.yaml index 9e18198902..f0b1a6e361 100644 --- a/.github/workflows/cargo-deny-runner.yaml +++ b/.github/workflows/cargo-deny-runner.yaml @@ -24,7 +24,7 @@ jobs: run: bash cargo-deny-generator.sh working-directory: ./.github/cargo-deny-composite-action/ env: - GOPATH: ${{ runner.workspace }}/kata-containers + GOPATH: ${{ github.workspace }}/kata-containers - name: Run Action if: ${{ !contains(github.event.pull_request.labels.*.name, 'force-skip-ci') }} uses: ./.github/cargo-deny-composite-action diff --git a/.github/workflows/ci-weekly.yaml b/.github/workflows/ci-weekly.yaml index 9cb4d7d4ed..8b0edbed49 100644 --- a/.github/workflows/ci-weekly.yaml +++ b/.github/workflows/ci-weekly.yaml @@ -83,4 +83,5 @@ jobs: commit-hash: ${{ inputs.commit-hash }} pr-number: ${{ inputs.pr-number }} target-branch: ${{ inputs.target-branch }} + tarball-suffix: -${{ inputs.tag }} secrets: inherit diff --git a/.github/workflows/docs-url-alive-check.yaml b/.github/workflows/docs-url-alive-check.yaml index a55e3c6f2e..a9c0389bbd 100644 --- a/.github/workflows/docs-url-alive-check.yaml +++ b/.github/workflows/docs-url-alive-check.yaml @@ -16,7 +16,7 @@ jobs: with: go-version: 1.22.2 env: - GOPATH: ${{ runner.workspace }}/kata-containers + GOPATH: ${{ github.workspace }}/kata-containers - name: Set env run: | echo "GOPATH=${{ github.workspace }}" >> "$GITHUB_ENV" diff --git a/.github/workflows/run-k8s-tests-on-amd64.yaml b/.github/workflows/run-k8s-tests-on-amd64.yaml index 66fe6b73d8..8a12687d32 100644 --- a/.github/workflows/run-k8s-tests-on-amd64.yaml +++ b/.github/workflows/run-k8s-tests-on-amd64.yaml @@ -86,11 +86,11 @@ jobs: - name: Install `bats` run: bash tests/integration/kubernetes/gha-run.sh install-bats - + - name: Run tests timeout-minutes: 30 run: bash tests/integration/kubernetes/gha-run.sh run-tests - + - name: Collect artifacts ${{ matrix.vmm }} if: always() run: bash tests/integration/kubernetes/gha-run.sh collect-artifacts @@ -99,7 +99,7 @@ jobs: - name: Archive artifacts ${{ matrix.vmm }} uses: actions/upload-artifact@v4 with: - name: k8s-tests-${{ matrix.vmm }}-${{ matrix.snapshotter }}-${{ matrix.k8s }}-${{ matrix.instance }}-${{ inputs.tag }} + name: k8s-tests-${{ matrix.vmm }}-${{ matrix.snapshotter }}-${{ matrix.k8s }}-${{ inputs.tag }} path: /tmp/artifacts retention-days: 1 diff --git a/.github/workflows/run-kata-coco-stability-tests.yaml b/.github/workflows/run-kata-coco-stability-tests.yaml index 42d46696d5..11ec21a139 100644 --- a/.github/workflows/run-kata-coco-stability-tests.yaml +++ b/.github/workflows/run-kata-coco-stability-tests.yaml @@ -21,6 +21,9 @@ on: required: false type: string default: "" + tarball-suffix: + required: false + type: string jobs: # Generate jobs for testing CoCo on non-TEE environments @@ -40,7 +43,6 @@ jobs: DOCKER_REPO: ${{ inputs.repo }} DOCKER_TAG: ${{ inputs.tag }} GH_PR_NUMBER: ${{ inputs.pr-number }} - KATA_HOST_OS: ${{ matrix.host_os }} KATA_HYPERVISOR: ${{ matrix.vmm }} # Some tests rely on that variable to run (or not) KBS: "true" diff --git a/.github/workflows/run-kata-coco-tests.yaml b/.github/workflows/run-kata-coco-tests.yaml index 47719247e2..34956a54d6 100644 --- a/.github/workflows/run-kata-coco-tests.yaml +++ b/.github/workflows/run-kata-coco-tests.yaml @@ -288,7 +288,6 @@ jobs: DOCKER_REPO: ${{ inputs.repo }} DOCKER_TAG: ${{ inputs.tag }} GH_PR_NUMBER: ${{ inputs.pr-number }} - KATA_HOST_OS: ${{ matrix.host_os }} KATA_HYPERVISOR: ${{ matrix.vmm }} # Some tests rely on that variable to run (or not) KBS: "true"