github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-06-28 00:07:16 +00:00
Code Issues Projects Releases Wiki Activity

fc: Add support for noflush cache option

Browse Source 
Firecracker supports noflush semantic via Unsafe cache type.
There is no support for direct i/o, remove it from config file

Fixes: #7823

Signed-off-by: Alexandru Matei <alexandru.matei@uipath.com>
This commit is contained in:
Alexandru Matei 2023-09-01 12:49:18 +03:00
parent 2ca781518a
commit d507d189bb
2 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/runtime/config/configuration-fc.toml.in
View File

@ -126,11 +126,6 @@ block_device_driver = "@DEFBLOCKSTORAGEDRIVER_FC@"
# Default false # Default false
#block_device_cache_set = true #block_device_cache_set = true
# Specifies cache-related options for block devices.
# Denotes whether use of O_DIRECT (bypass the host page cache) is enabled.
# Default false
#block_device_cache_direct = true
# Specifies cache-related options for block devices. # Specifies cache-related options for block devices.
# Denotes whether flush requests for the device are ignored. # Denotes whether flush requests for the device are ignored.
# Default false # Default false

11
src/runtime/virtcontainers/fc.go
View File

@ -835,6 +835,17 @@ func (fc *firecracker) createDiskPool(ctx context.Context) error {
PathOnHost: &jailedDrive, PathOnHost: &jailedDrive,
} }
if fc.config.BlockDeviceCacheSet {
var cacheOption string
if fc.config.BlockDeviceCacheNoflush {
cacheOption = models.DriveCacheTypeUnsafe
} else {
cacheOption = models.DriveCacheTypeWriteback
}
drive.CacheType = &cacheOption
}
fc.fcConfig.Drives = append(fc.fcConfig.Drives, drive) fc.fcConfig.Drives = append(fc.fcConfig.Drives, drive)
} }