release: Simplify the create-new-release action of release.sh

Now that the version is an invariant for the entire workflow, it
isn't required to obtain it with an environment variable. Just
rely on the content of the `VERSION` file like other actions.

Fixes #9064 - part VI

Signed-off-by: Greg Kurz <groug@kaod.org>

.github/workflows/release.yaml

@@ -11,11 +11,6 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Get the new release version
-        run: |
-          release_version=$(./tools/packaging/release/release.sh release-version)
-          echo "RELEASE_VERSION=$release_version" >> "$GITHUB_ENV"
-
       - name: Create a new release
         run: |
           ./tools/packaging/release/release.sh create-new-release

tools/packaging/release/release.sh

@@ -108,9 +108,10 @@ EOF
 
 function _create_new_release()
 {
-	_check_required_env_var "RELEASE_VERSION"
 	_check_required_env_var "GH_TOKEN"
 
+	RELEASE_VERSION="$(_release_version)"
+
 	_create_our_own_notes
 
 	gh release create ${RELEASE_VERSION} \