From dd2878a9c85cff14b1ce43b1a3571b582f5c7fd3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luk=C3=A1=C5=A1=20Doktor?= Date: Thu, 18 Jul 2024 13:05:51 +0200 Subject: [PATCH] ci: Unify character for separating items MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit the test names are using `;` and regexps were designed to use `,` but during development simply joined the expressions by `|`. This should work but might be confusing so let's go with the semi-colon separator everywhere. Signed-off-by: Lukáš Doktor --- tools/testing/gatekeeper/jobs.py | 4 ++-- tools/testing/gatekeeper/skips.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/gatekeeper/jobs.py b/tools/testing/gatekeeper/jobs.py index 94b6904293..5a5db4e723 100644 --- a/tools/testing/gatekeeper/jobs.py +++ b/tools/testing/gatekeeper/jobs.py @@ -45,7 +45,7 @@ class Checker: self.latest_commit_sha = os.getenv("COMMIT_HASH") required_jobs = os.getenv("REQUIRED_JOBS") if required_jobs: - required_jobs = required_jobs.split(",") + required_jobs = required_jobs.split(";") else: required_jobs = [] required_regexps = os.getenv("REQUIRED_REGEXPS") @@ -53,7 +53,7 @@ class Checker: # TODO: Add way to specify minimum amount of tests # (eg. via \d+: prefix) and check it in status if required_regexps: - for regexp in required_regexps.split(","): + for regexp in required_regexps.split(";"): self.required_regexps.append(re.compile(regexp)) if not required_jobs and not self.required_regexps: raise RuntimeError("No REQUIRED_JOBS or REQUIRED_REGEXPS defined") diff --git a/tools/testing/gatekeeper/skips.py b/tools/testing/gatekeeper/skips.py index dcb6920094..1f08af18d7 100644 --- a/tools/testing/gatekeeper/skips.py +++ b/tools/testing/gatekeeper/skips.py @@ -66,7 +66,7 @@ class Checks: if values.get("regexps"): required_regexps.add(values["regexps"]) print(';'.join(required_tests)) - print('|'.join(required_regexps)) + print(';'.join(required_regexps)) return 0 def get_features(self, target_branch):