From f2a211725291d43bf562381edbb4342db0aa5f82 Mon Sep 17 00:00:00 2001
From: stevenhorsman <steven@uk.ibm.com>
Date: Fri, 11 Apr 2025 14:37:52 +0100
Subject: [PATCH] tests: k8s: Retry output of kubectl exec in k8s-cpu-ns

We are seeing failures in this test, where the output of
the kubectl exec command seems to be blank, so try
retrying the exec like #11024

Fixes: #11133
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
---
 tests/integration/kubernetes/k8s-cpu-ns.bats  | 35 +++++++++++++++----
 .../runtimeclass_workloads/pod-cpu.yaml       |  2 +-
 2 files changed, 30 insertions(+), 7 deletions(-)

diff --git a/tests/integration/kubernetes/k8s-cpu-ns.bats b/tests/integration/kubernetes/k8s-cpu-ns.bats
index e262b91b4..bc8dc6ac8 100644
--- a/tests/integration/kubernetes/k8s-cpu-ns.bats
+++ b/tests/integration/kubernetes/k8s-cpu-ns.bats
@@ -66,8 +66,18 @@ setup() {
 	# Check the total of cpus
 	for _ in $(seq 1 "$retries"); do
 		# Get number of cpus
-		total_cpus_container=$(kubectl exec pod/"$pod_name" -c "$container_name" \
+		# Retry "kubectl exec" several times in case it unexpectedly returns an empty output string,
+		# in an attempt to work around issues similar to https://github.com/kubernetes/kubernetes/issues/124571.
+		for _ in {1..10}; do
+			total_cpus_container=$(kubectl exec pod/"$pod_name" -c "$container_name" \
 			-- "${exec_num_cpus_cmd[@]}")
+			if [[ -n "${total_cpus_container}" ]]; then
+				break
+			fi
+			warn "Empty output from kubectl exec" >&2
+			sleep 1
+		done
+
 		# Verify number of cpus
 		[ "$total_cpus_container" -le "$total_cpus" ]
 		[ "$total_cpus_container" -eq "$total_cpus" ] && break
@@ -76,16 +86,29 @@ setup() {
 	[ "$total_cpus_container" -eq "$total_cpus" ]
 
 	# Check the total of requests
-	total_requests_container=$(kubectl exec $pod_name -c $container_name \
-		-- "${exec_weightsyspath_cmd[@]}")
+	for _ in {1..10}; do
+		total_requests_container=$(kubectl exec $pod_name -c $container_name \
+			-- "${exec_weightsyspath_cmd[@]}")
+		if [[ -n "${total_requests_container}" ]]; then
+			break
+		fi
+		warn "Empty output from kubectl exec" >&2
+		sleep 1
+	done
 	info "total_requests_container = $total_requests_container"
 
 	[ "$total_requests_container" -eq "$total_requests" ]
 
 	# Check the cpus inside the container
-
-	read total_cpu_quota total_cpu_period <<< $(kubectl exec $pod_name -c $container_name \
-		-- "${exec_maxsyspath_cmd[@]}")
+	for _ in {1..10}; do
+		maxsyspath=$(kubectl exec $pod_name -c $container_name -- "${exec_maxsyspath_cmd[@]}")
+		if [[ -n "${maxsyspath}" ]]; then
+			break
+		fi
+		warn "Empty output from kubectl exec" >&2
+		sleep 1
+	done
+	read total_cpu_quota total_cpu_period <<< ${maxsyspath}
 
 	division_quota_period=$(echo $((total_cpu_quota/total_cpu_period)))
 
diff --git a/tests/integration/kubernetes/runtimeclass_workloads/pod-cpu.yaml b/tests/integration/kubernetes/runtimeclass_workloads/pod-cpu.yaml
index cf04c4b50..00cf10ade 100644
--- a/tests/integration/kubernetes/runtimeclass_workloads/pod-cpu.yaml
+++ b/tests/integration/kubernetes/runtimeclass_workloads/pod-cpu.yaml
@@ -15,7 +15,7 @@ spec:
     image: quay.io/prometheus/busybox:latest
     command:
         - sleep
-        - "30"
+        - "infinity"
     resources:
       limits:
         cpu: "1"