From ee505828489125276e7c76623ff0d6a15cc022a1 Mon Sep 17 00:00:00 2001 From: Konstantin Khlebnikov Date: Thu, 25 Jul 2024 12:04:52 +0200 Subject: [PATCH] runtime: log vm start error before cleanup Return of proper error to the initiator is not guaranteed. Method StopVM could kill shim process together with VM pieces. Signed-off-by: Konstantin Khlebnikov --- src/runtime/virtcontainers/sandbox.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/runtime/virtcontainers/sandbox.go b/src/runtime/virtcontainers/sandbox.go index ac0d35e9c8..33244bc535 100644 --- a/src/runtime/virtcontainers/sandbox.go +++ b/src/runtime/virtcontainers/sandbox.go @@ -1458,6 +1458,8 @@ func (s *Sandbox) startVM(ctx context.Context, prestartHookFunc func(context.Con defer func() { if err != nil { + // Log error, otherwise nobody might see it - StopVM could kill this process. + s.Logger().WithError(err).Error("Cannot start VM") s.hypervisor.StopVM(ctx, false) } }()