From 5c7a685f960b87ffd77efb8caed97b6ba999759d Mon Sep 17 00:00:00 2001 From: "James O. D. Hunt" Date: Mon, 18 Dec 2017 21:52:55 +0000 Subject: [PATCH 1/2] CI: Require 2 approvals for pullapprove Change the pullapprove configuration to require two acks before a PR can be approved (for parity with the agent). Fixes #10. Signed-off-by: James O. D. Hunt --- .pullapprove.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index bf30ea1439..ee290078f6 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -26,6 +26,6 @@ group_defaults: groups: approvers: - required: 1 + required: 2 teams: - builder From c0d3ef8c1b4465ecc3e95f5771b6a893ea5e9a3c Mon Sep 17 00:00:00 2001 From: "James O. D. Hunt" Date: Mon, 18 Dec 2017 21:53:23 +0000 Subject: [PATCH 2/2] CI: Add rfc logic to pullapprove config For parity with the agent, disallow merging of RFC branches. Signed-off-by: James O. D. Hunt --- .pullapprove.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index ee290078f6..56aa0126cc 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -6,10 +6,11 @@ requirements: # Disallow approval of PRs still under development always_pending: - title_regex: 'WIP' + title_regex: '(WIP|RFC)' labels: - do-not-merge - wip + - rfc explanation: 'Work in progress - do not merge' group_defaults: