From 46720c61c11b8f79f079c546e17f1b2769fb9040 Mon Sep 17 00:00:00 2001 From: bin Date: Tue, 28 Sep 2021 18:00:58 +0800 Subject: [PATCH] runtime: set tags for trace span Set tags for trace span in hook.go and remove FIXME. Fixes: #2749 Signed-off-by: bin --- src/runtime/pkg/katautils/hook.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/runtime/pkg/katautils/hook.go b/src/runtime/pkg/katautils/hook.go index 8aeb6678e4..7933a182e1 100644 --- a/src/runtime/pkg/katautils/hook.go +++ b/src/runtime/pkg/katautils/hook.go @@ -35,11 +35,8 @@ func hookLogger() *logrus.Entry { func runHook(ctx context.Context, hook specs.Hook, cid, bundlePath string) error { span, _ := katatrace.Trace(ctx, hookLogger(), "runHook", hookTracingTags) defer span.End() - - // FIXME - // span.LogFields( - // log.String("hook-name", hook.Path), - // log.String("hook-args", strings.Join(hook.Args, " "))) + katatrace.AddTag(span, "path", hook.Path) + katatrace.AddTag(span, "args", hook.Args) state := specs.State{ Pid: syscall.Gettid(),