From ee6a590db17807355d08325ec1ad9c06c726a97e Mon Sep 17 00:00:00 2001 From: Tim Zhang Date: Fri, 2 Apr 2021 18:21:44 +0800 Subject: [PATCH] agent: add test test_pipestream_shutdown Make sure PipeStream::shutdown() do not close the inner fd. Signed-off-by: Tim Zhang --- src/agent/rustjail/src/pipestream.rs | 34 ++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/src/agent/rustjail/src/pipestream.rs b/src/agent/rustjail/src/pipestream.rs index 1312a4b6a4..ab73291801 100644 --- a/src/agent/rustjail/src/pipestream.rs +++ b/src/agent/rustjail/src/pipestream.rs @@ -167,3 +167,37 @@ impl AsyncWrite for PipeStream { Poll::Ready(Ok(())) } } + +#[cfg(test)] +mod tests { + use super::*; + use nix::fcntl::OFlag; + use tokio::io::{AsyncReadExt, AsyncWriteExt}; + + #[tokio::test] + // Shutdown should never close the inner fd. + async fn test_pipestream_shutdown() { + let (_, wfd1) = unistd::pipe2(OFlag::O_CLOEXEC).unwrap(); + let mut writer1 = PipeStream::new(wfd1).unwrap(); + + // if close fd in shutdown, the fd will be reused + // and the test will failed + let _ = writer1.shutdown().await.unwrap(); + + // let _ = unistd::close(wfd1); + + let (rfd2, wfd2) = unistd::pipe2(OFlag::O_CLOEXEC).unwrap(); // reuse fd number, rfd2 == wfd1 + + let mut reader2 = PipeStream::new(rfd2).unwrap(); + let mut writer2 = PipeStream::new(wfd2).unwrap(); + + // deregister writer1, then reader2 which has the same fd will be deregistered from epoll + drop(writer1); + + let _ = writer2.write(b"1").await; + + let mut content = vec![0u8; 1]; + // Will Block here if shutdown close the fd. + let _ = reader2.read(&mut content).await; + } +}