From eedacc1572b7e4cd4bb359e12ffd7c6b95ff054d Mon Sep 17 00:00:00 2001 From: Nitesh Konkar Date: Sun, 29 Jul 2018 03:02:26 +0530 Subject: [PATCH] build_image.sh: OPTIND prevent unwanted word-splitting shift $((OPTIND-1)) can be unsafe.To prevent unwanted word-splitting all parameter expansions should be double-quoted. Use the safe form for the command: shift "$((OPTIND-1))" Fixes: #109 Signed-off-by: Nitesh Konkar niteshkonkar@in.ibm.com --- obs-packaging/kata-containers-image/build_image.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/obs-packaging/kata-containers-image/build_image.sh b/obs-packaging/kata-containers-image/build_image.sh index a1b116d994..1975a46742 100755 --- a/obs-packaging/kata-containers-image/build_image.sh +++ b/obs-packaging/kata-containers-image/build_image.sh @@ -105,7 +105,7 @@ main(){ # Agent version [ -n "${agent_version}" ] || agent_version="${kata_version}" - shift $(( "$OPTIND" - 1 )) + shift "$(( $OPTIND - 1 ))" git clone "$osbuilder_url" "${tmp_dir}/osbuilder" pushd "${tmp_dir}/osbuilder" git checkout "${kata_osbuilder_version}"