github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-08-14 06:06:12 +00:00
Code Issues Projects Releases Wiki Activity

kata-deploy: Modify containerd config atomically

Browse Source 
the kata-deploy pod can be restarted/interrupted at any time which might
lead to partially modified files. Let's use a loop to configure
containerd to minimize the probability of partial modification.

Note this is still not perfect as there is a short non-atomic part, but
given the order of changes it shouldn't result in partially modified
files.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
This commit is contained in:
Lukáš Doktor 2025-01-23 17:51:43 +01:00
parent 8bf3582e83
commit f47d643b82
No known key found for this signature in database
GPG Key ID: 26B362E47FCF22C1
1 changed files with 28 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
tools/packaging/kata-deploy/scripts/kata-deploy.sh
View File

@ -592,14 +592,14 @@ function configure_containerd_runtime() {
local runtime="kata-${adjusted_shim_to_multi_install}" local runtime="kata-${adjusted_shim_to_multi_install}"
local configuration="configuration-${shim}" local configuration="configuration-${shim}"
local pluginid=cri local pluginid=cri
local configuration_file="${containerd_conf_file}" local configuration_file="$3"
# Properly set the configuration file in case drop-in files are supported # Properly set the configuration file in case drop-in files are supported
if [ $use_containerd_drop_in_conf_file = "true" ]; then if [ $use_containerd_drop_in_conf_file = "true" ]; then
configuration_file="/host${containerd_drop_in_conf_file}" configuration_file="/host${containerd_drop_in_conf_file}"
fi fi
local containerd_root_conf_file="$containerd_conf_file" local containerd_root_conf_file="$configuration_file"
if [[ "$1" =~ ^(k0s-worker|k0s-controller)$ ]]; then if [[ "$1" =~ ^(k0s-worker|k0s-controller)$ ]]; then
containerd_root_conf_file="/etc/containerd/containerd.toml" containerd_root_conf_file="/etc/containerd/containerd.toml"
fi fi
@ -649,15 +649,33 @@ function configure_containerd() {
mkdir -p /etc/containerd/ mkdir -p /etc/containerd/
if [ $use_containerd_drop_in_conf_file = "false" ] && [ -f "$containerd_conf_file" ]; then # To avoid problems when this pod gets re-created let's be a bit paranoiac
# only backup in case drop-in files are not supported, and when doing the backup # and try to configure/backup the most recent configuration more-less
# only do it if a backup doesn't already exist (don't override original) # atomically. This shouldn't be that needed for drop-in configuration
cp -n "$containerd_conf_file" "$containerd_conf_file_backup" # but shouldn't harm either.
fi local tmp_config_file=$(mktemp)
( for i in {1..10}; do
local pre_config="$(cat "$containerd_conf_file")"
echo "$pre_config" > "$tmp_config_file"
for shim in "${shims[@]}"; do for shim in "${shims[@]}"; do
configure_containerd_runtime "$1" "$shim" configure_containerd_runtime "$1" "$shim" "$tmp_config_file"
done done
if [ "$(cat "$containerd_conf_file")" == "$pre_config" ]; then
# Nobody modified the containerd file, write our changes in
# least dangerous way (no atomicity of this section...)
if [ $use_containerd_drop_in_conf_file = "false" ] && [ -f "$containerd_conf_file" ]; then
# only backup in case drop-in files are not supported, and when doing the backup
# only do it if a backup doesn't already exist (don't override original)
cp -n "$containerd_conf_file" "$containerd_conf_file_backup"
fi
mv -f "$tmp_config_file" "$containerd_conf_file"
exit 0
fi
sleep $(($RANDOM / 1000))
done ) || die "Failed to configure containerd in 10 iterations, is someone else modifying ${containerd_conf_file}?"
rm -f "$tmp_config_file"
if [ $use_containerd_drop_in_conf_file = "true" ]; then if [ $use_containerd_drop_in_conf_file = "true" ]; then
tomlq -i -t $(printf '.imports|=.+["%s"]' ${containerd_drop_in_conf_file}) ${containerd_conf_file} tomlq -i -t $(printf '.imports|=.+["%s"]' ${containerd_drop_in_conf_file}) ${containerd_conf_file}