From f4feba9a9f149fad6db0b9a0e4906841ce9cbe31 Mon Sep 17 00:00:00 2001 From: Peng Tao Date: Thu, 27 Sep 2018 18:26:53 +0800 Subject: [PATCH] release: fix release tag check We should make sure ${tag} fully matches otherwise we cannot differentiate `1.3.0` vs. `1.3.0-rc1`, nor `1.3.0` vs. `11.3.0`. Fixes: #196 Signed-off-by: Peng Tao --- release/tag_repos.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/release/tag_repos.sh b/release/tag_repos.sh index c85d6150d3..049a445d6a 100755 --- a/release/tag_repos.sh +++ b/release/tag_repos.sh @@ -144,8 +144,8 @@ create_github_release() { repo_dir=${1:-} tag=${2:-} [ -d "${repo_dir}" ] || die "No repository directory" - [ -n "${tag}" ] || die "No repository directory" - if ! "${hub_bin}" release | grep "${tag}"; then + [ -n "${tag}" ] || die "No tag specified" + if ! "${hub_bin}" release | grep -q "^${tag}$"; then info "Creating Github release" "${hub_bin}" -C "${repo_dir}" release create -m "${PROJECT} ${tag}" "${tag}" else