From f6cd3930c5ad25dd125b477ab3fa7592e37c00d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Fri, 8 Sep 2023 14:25:29 +0200 Subject: [PATCH] ci: k8s: Remove useless skip statement from tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There's absolutely no need to have the skip check as part of the test itself when it's already done as part of the setup function. We're only touching the files here that were touched in the previous commit. Signed-off-by: Fabiano FidĂȘncio --- tests/integration/kubernetes/k8s-cpu-ns.bats | 6 ------ tests/integration/kubernetes/k8s-credentials-secrets.bats | 2 -- tests/integration/kubernetes/k8s-file-volume.bats | 1 - tests/integration/kubernetes/k8s-projected-volume.bats | 2 -- 4 files changed, 11 deletions(-) diff --git a/tests/integration/kubernetes/k8s-cpu-ns.bats b/tests/integration/kubernetes/k8s-cpu-ns.bats index d8db75d17a..878e761a26 100644 --- a/tests/integration/kubernetes/k8s-cpu-ns.bats +++ b/tests/integration/kubernetes/k8s-cpu-ns.bats @@ -29,12 +29,6 @@ setup() { } @test "Check CPU constraints" { - [ "${KATA_HYPERVISOR}" == "firecracker" ] && skip "test not working see: ${fc_limitations}" - [ "${KATA_HYPERVISOR}" == "dragonball" ] && skip "test not working see: ${dragonball_limitations}" - ( [ "${KATA_HYPERVISOR}" == "qemu-tdx" ] || [ "${KATA_HYPERVISOR}" == "qemu-snp" ] || [ "${KATA_HYPERVISOR}" == "qemu-sev" ] ) \ - && skip "TEEs do not support memory / CPU hotplug" - - # Create the pod kubectl create -f "${pod_config_dir}/pod-cpu.yaml" diff --git a/tests/integration/kubernetes/k8s-credentials-secrets.bats b/tests/integration/kubernetes/k8s-credentials-secrets.bats index b8c03dd9cc..8becf2e2e3 100644 --- a/tests/integration/kubernetes/k8s-credentials-secrets.bats +++ b/tests/integration/kubernetes/k8s-credentials-secrets.bats @@ -16,8 +16,6 @@ setup() { } @test "Credentials using secrets" { - [ "${KATA_HYPERVISOR}" == "firecracker" ] && skip "test not working see: ${fc_limitations}" - secret_name="test-secret" pod_name="secret-test-pod" second_pod_name="secret-envars-test-pod" diff --git a/tests/integration/kubernetes/k8s-file-volume.bats b/tests/integration/kubernetes/k8s-file-volume.bats index 70462c223d..d849db2edd 100644 --- a/tests/integration/kubernetes/k8s-file-volume.bats +++ b/tests/integration/kubernetes/k8s-file-volume.bats @@ -21,7 +21,6 @@ setup() { } @test "Test readonly volume for pods" { - [ "${KATA_HYPERVISOR}" == "firecracker" ] && skip "test not working see: ${fc_limitations}" # Write test body to temp file exec_host "echo "$file_body" > $tmp_file" diff --git a/tests/integration/kubernetes/k8s-projected-volume.bats b/tests/integration/kubernetes/k8s-projected-volume.bats index 9c6484b54e..87160eeb50 100644 --- a/tests/integration/kubernetes/k8s-projected-volume.bats +++ b/tests/integration/kubernetes/k8s-projected-volume.bats @@ -16,8 +16,6 @@ setup() { } @test "Projected volume" { - [ "${KATA_HYPERVISOR}" == "firecracker" ] && skip "test not working see: ${fc_limitations}" - password="1f2d1e2e67df" username="admin" pod_name="test-projected-volume"