mirror of
https://github.com/kata-containers/kata-containers.git
synced 2025-04-30 04:34:27 +00:00
runtime: Clean up mock hook logs in tests
The tests in hook_test.go run a mock hook binary, which does some debug logging to /tmp/mock_hook.log. Currently we don't clean up those logs when the tests are done. Use a test cleanup function to do this. Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
parent
90b2f5b776
commit
f7ba21c86f
@ -22,6 +22,7 @@ var testContainerIDHook = "test-container-id"
|
|||||||
var testControllerIDHook = "test-controller-id"
|
var testControllerIDHook = "test-controller-id"
|
||||||
var testBinHookPath = "mockhook/hook"
|
var testBinHookPath = "mockhook/hook"
|
||||||
var testBundlePath = "/test/bundle"
|
var testBundlePath = "/test/bundle"
|
||||||
|
var mockHookLogFile = "/tmp/mock_hook.log"
|
||||||
|
|
||||||
func getMockHookBinPath() string {
|
func getMockHookBinPath() string {
|
||||||
return testBinHookPath
|
return testBinHookPath
|
||||||
@ -49,12 +50,17 @@ func createWrongHook() specs.Hook {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func cleanMockHookLogFile() {
|
||||||
|
_ = os.Remove(mockHookLogFile)
|
||||||
|
}
|
||||||
|
|
||||||
func TestRunHook(t *testing.T) {
|
func TestRunHook(t *testing.T) {
|
||||||
if tc.NotValid(ktu.NeedRoot()) {
|
if tc.NotValid(ktu.NeedRoot()) {
|
||||||
t.Skip(ktu.TestDisabledNeedRoot)
|
t.Skip(ktu.TestDisabledNeedRoot)
|
||||||
}
|
}
|
||||||
|
|
||||||
assert := assert.New(t)
|
assert := assert.New(t)
|
||||||
|
t.Cleanup(cleanMockHookLogFile)
|
||||||
|
|
||||||
ctx := context.Background()
|
ctx := context.Background()
|
||||||
spec := specs.Spec{}
|
spec := specs.Spec{}
|
||||||
@ -87,6 +93,7 @@ func TestPreStartHooks(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
assert := assert.New(t)
|
assert := assert.New(t)
|
||||||
|
t.Cleanup(cleanMockHookLogFile)
|
||||||
|
|
||||||
ctx := context.Background()
|
ctx := context.Background()
|
||||||
|
|
||||||
@ -129,6 +136,7 @@ func TestPostStartHooks(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
assert := assert.New(t)
|
assert := assert.New(t)
|
||||||
|
t.Cleanup(cleanMockHookLogFile)
|
||||||
|
|
||||||
ctx := context.Background()
|
ctx := context.Background()
|
||||||
|
|
||||||
@ -173,6 +181,7 @@ func TestPostStopHooks(t *testing.T) {
|
|||||||
assert := assert.New(t)
|
assert := assert.New(t)
|
||||||
|
|
||||||
ctx := context.Background()
|
ctx := context.Background()
|
||||||
|
t.Cleanup(cleanMockHookLogFile)
|
||||||
|
|
||||||
// Hooks field is nil
|
// Hooks field is nil
|
||||||
spec := specs.Spec{}
|
spec := specs.Spec{}
|
||||||
|
Loading…
Reference in New Issue
Block a user